[GitHub] [accumulo] DomGarguilo commented on a change in pull request #2580: Convert defaultTimeoutSeconds() to defaultTimeout()

[GitBox <gi...@apache.org>]

DomGarguilo commented on a change in pull request #2580:
URL: https://github.com/apache/accumulo/pull/2580#discussion_r831270271



##########
File path: test/src/main/java/org/apache/accumulo/harness/AccumuloITBase.java
##########
@@ -111,19 +111,18 @@ public static File createTestDir(String name) {
     }
 
     // if either value is zero, apply a very long timeout (effectively no timeout)
-    int totalTimeoutSeconds = timeoutFactor * defaultTimeoutSeconds();
-    if (totalTimeoutSeconds == 0) {
+    if (timeoutFactor == 0 || defaultTimeoutDuration().isZero()) {

Review comment:
       > We don't want infinite timeouts by default, only if the user explicitly set it with `-Dtimeout.factor=0`.
   
   I don't think the timeout will be infinite by default. I think the only cases where the infinite timeout would be applied (before [c03f65e](https://github.com/apache/accumulo/pull/2580/commits/c03f65e720d08abd1341872295d7faaa241d3b93)) would be if the user explicitly set it with `-Dtimeout.factor=0`, or if `defaultTimeout()` was explicitly overridden to return a duration of zero.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org