You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/30 21:48:28 UTC

[GitHub] [druid] clintropolis commented on a change in pull request #10147: Support rolling log files

clintropolis commented on a change in pull request #10147:
URL: https://github.com/apache/druid/pull/10147#discussion_r697750331



##########
File path: examples/bin/node.sh
##########
@@ -64,7 +64,7 @@ case $command in
     fi
     JAVA="$JAVA_BIN_DIR/java"
 
-    nohup $JAVA `cat $CONF_DIR/$nodeType/jvm.config | xargs` -cp $CONF_DIR/_common:$CONF_DIR/$nodeType:$LIB_DIR/*:$HADOOP_CONF_DIR org.apache.druid.cli.Main server $nodeType >> $LOG_DIR/$nodeType.log 2>&1 &
+    nohup $JAVA -Ddruid.node.type=$nodeType -Druid.log.path=$LOG_DIR `cat $CONF_DIR/$nodeType/jvm.config | xargs` -cp $CONF_DIR/_common:$CONF_DIR/$nodeType:$LIB_DIR/*:$HADOOP_CONF_DIR org.apache.druid.cli.Main server $nodeType >> /dev/null 2>&1 &

Review comment:
       typo? `-Druid.log.path=$LOG_DIR` -> `-Ddruid.log.path=$LOG_DIR`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org