You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/09/28 06:28:02 UTC
[kudu-CR] KUDU-2055 [part 5]: Incorporate BlockDeletionTransaction in block deletions
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8163
Change subject: KUDU-2055 [part 5]: Incorporate BlockDeletionTransaction in block deletions
......................................................................
KUDU-2055 [part 5]: Incorporate BlockDeletionTransaction in block deletions
This patches incorporates fs::BlockDeletionTransaction API in tablet
metadata's orphaned block deletions to improve overall performance of
batched block deletions, such as delete a tablet.
Change-Id: I1bfac61a70b45d9f27d807f22bc21e582da2dd97
---
M src/kudu/tablet/tablet_metadata.cc
1 file changed, 7 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/8163/1
--
To view, visit http://gerrit.cloudera.org:8080/8163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bfac61a70b45d9f27d807f22bc21e582da2dd97
Gerrit-Change-Number: 8163
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] KUDU-2055 [part 5]: Incorporate BlockDeletionTransaction in block deletions
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8163 )
Change subject: KUDU-2055 [part 5]: Incorporate BlockDeletionTransaction in block deletions
......................................................................
Patch Set 1:
> (1 comment)
>
> Anything worth testing here?
Functionalities wise, coalescing the block deletions should behave the same as before. So I don't see the need for extra test coverage. But we may want to add a performance test?
--
To view, visit http://gerrit.cloudera.org:8080/8163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bfac61a70b45d9f27d807f22bc21e582da2dd97
Gerrit-Change-Number: 8163
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Oct 2017 18:17:51 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2055 [part 5]: Incorporate BlockDeletionTransaction in block deletions
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8163 )
Change subject: KUDU-2055 [part 5]: Incorporate BlockDeletionTransaction in block deletions
......................................................................
Patch Set 1:
(1 comment)
Anything worth testing here?
http://gerrit.cloudera.org:8080/#/c/8163/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8163/1//COMMIT_MSG@10
PS1, Line 10: to improve overall performance of
: batched block deletions, such as delete a tablet.
to improve overall performance of tablet deletion by batching up the individual blocks being deleted.
--
To view, visit http://gerrit.cloudera.org:8080/8163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bfac61a70b45d9f27d807f22bc21e582da2dd97
Gerrit-Change-Number: 8163
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 02 Oct 2017 22:33:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2055 [part 5]: Incorporate BlockDeletionTransaction in block deletions
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/8163 )
Change subject: KUDU-2055 [part 5]: Incorporate BlockDeletionTransaction in block deletions
......................................................................
Abandoned
Abandon it as this change is no longer valid and is already included in previous patch. I will add a performance test in another patch later.
--
To view, visit http://gerrit.cloudera.org:8080/8163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1bfac61a70b45d9f27d807f22bc21e582da2dd97
Gerrit-Change-Number: 8163
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins