Re: Review Request 33996: Implement HdfsResouces and it's usage

[Andrew Onischuk <ao...@hortonworks.com>]

> On May 11, 2015, 6:22 p.m., Jonathan Hurley wrote:
> > -1 This commit adds back "import *" to python files where it was removed. Additionally, the fast-hdfs-resource.jar should be copied if not found; we should not rely on the RPM to install it.

Both of those are already resolved in branch-2.2 and trunk. Closing this review now.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33996/#review83255
-----------------------------------------------------------


On May 9, 2015, 8:36 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33996/
> -----------------------------------------------------------
> 
> (Updated May 9, 2015, 8:36 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11034
>     https://issues.apache.org/jira/browse/AMBARI-11034
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> -
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/constants.py 99ff679 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_hdp_version.py ed34c02 
>   ambari-common/src/main/python/resource_management/libraries/functions/version.py d9f20da 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py 7a3401e 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 421a981 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py 39e4b97 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py a33857c 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 89f0224 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params_linux.py ddb829e 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py 2600141 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py 8b5db38 
>   ambari-server/src/main/resources/stacks/HDP/2.2/configuration/cluster-env.xml 281b821 
> 
> Diff: https://reviews.apache.org/r/33996/diff/
> 
> 
> Testing
> -------
> 
> tested HA + non-secure/secure - 2.3 stack
> tested non-secure/secure - 2.2 stack
> tested deploy - stack 2.0
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>