[jira] [Commented] (KUDU-2479) Flume sink should properly shade its dependencies that are incompatible with flume

["Mike Percy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KUDU-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517586#comment-16517586 ] 

Mike Percy commented on KUDU-2479:
----------------------------------

Thanks for the fix, Ferenc! This is great.

> Flume sink should properly shade its dependencies that are incompatible with flume
> ----------------------------------------------------------------------------------
>
>                 Key: KUDU-2479
>                 URL: https://issues.apache.org/jira/browse/KUDU-2479
>             Project: Kudu
>          Issue Type: Bug
>            Reporter: Ferenc Szabo
>            Assignee: Ferenc Szabo
>            Priority: Major
>
> The kudu-flume-sink depends on a different guava version than flume itself and in its current state it does not work with flume.
> Dependencies should be shaded and relocated
> currently the class extracted from the jar file does not use the shaded guava:
> {noformat}
> javap -c org.apache.kudu.flume.sink.KuduSink |grep google
>       21: invokestatic  #8                  // Method com/google/common/base/Preconditions.checkState:(ZLjava/lang/Object;)V
>       18: invokestatic  #49                 // Method com/google/common/base/Preconditions.checkNotNull:(Ljava/lang/Object;Ljava/lang/String;Ljava/lang/Object;)Ljava/lang/Object;
>       40: invokestatic  #49                 // Method com/google/common/base/Preconditions.checkNotNull:(Ljava/lang/Object;Ljava/lang/String;Ljava/lang/Object;)Ljava/lang/Object;
>      139: invokevirtual #73                 // Method org/apache/flume/Context.getSubProperties:(Ljava/lang/String;)Lcom/google/common/collect/ImmutableMap;
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)