You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/26 12:54:38 UTC

[GitHub] [hudi] nsivabalan opened a new pull request #1767: [MINOR] Adding test to WriteClient to validate update partition path with global bloom

nsivabalan opened a new pull request #1767:
URL: https://github.com/apache/hudi/pull/1767


   ## What is the purpose of the pull request
   
   Adding a test to validate update partition path
   
   ## Brief change log
   
   ## Verify this pull request
   
   this patch is just adding tests
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #1767: [MINOR] Adding test to WriteClient to validate update partition path with global bloom

Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #1767:
URL: https://github.com/apache/hudi/pull/1767#issuecomment-650793135


   > @xushiyan Could you please review this PR since you did the related work before.
   
   @leesf Yes I can look into this soon.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] vinothchandar commented on pull request #1767: [MINOR] Adding test to WriteClient to validate update partition path with global bloom

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #1767:
URL: https://github.com/apache/hudi/pull/1767#issuecomment-650698829


   @nsivabalan this is more than the 50 lines we agreed on for MINOR prefix. can you please file a JIRA and let me know if you think this quallifies for the MINOR prefix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan closed pull request #1767: [HUDI-1059] Adding test to WriteClient to validate update partition path with global bloom

Posted by GitBox <gi...@apache.org>.
nsivabalan closed pull request #1767:
URL: https://github.com/apache/hudi/pull/1767


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #1767: [HUDI-1059] Adding test to WriteClient to validate update partition path with global bloom

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #1767:
URL: https://github.com/apache/hudi/pull/1767#issuecomment-653775627


   @xushiyan : can you review this when you get time. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #1767: [HUDI-1059] Adding test to WriteClient to validate update partition path with global bloom

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #1767:
URL: https://github.com/apache/hudi/pull/1767#issuecomment-653805963


   Closing this in favor of https://github.com/apache/hudi/pull/1793


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] leesf commented on pull request #1767: [MINOR] Adding test to WriteClient to validate update partition path with global bloom

Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #1767:
URL: https://github.com/apache/hudi/pull/1767#issuecomment-650524267


   @xushiyan Could you please review this PR since you did the related work before.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org