You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/23 07:41:37 UTC

[GitHub] [maven-indexer] bmarwell commented on a change in pull request #75: Remove guava dependency from indexer-core

bmarwell commented on a change in pull request #75:
URL: https://github.com/apache/maven-indexer/pull/75#discussion_r563033687



##########
File path: indexer-core/src/main/java/org/apache/maven/index/ArtifactInfo.java
##########
@@ -431,7 +429,8 @@ public Gav calculateGav()
     public String toString()
     {
         final StringBuilder result = new StringBuilder( getUinfo() );
-        if ( !Strings.isNullOrEmpty( getPackaging() ) )
+        String packaging = getPackaging();
+        if (packaging != null && !getPackaging().isEmpty())

Review comment:
       Don't call the method here, it could yield null.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org