[GitHub] [kafka] showuon commented on a change in pull request #10903: KAFKA-12473: make "range, cooperative-sticky" as the default assignor

[GitBox <gi...@apache.org>]

showuon commented on a change in pull request #10903:
URL: https://github.com/apache/kafka/pull/10903#discussion_r661925589



##########
File path: core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala
##########
@@ -412,13 +413,15 @@ abstract class AbstractConsumerTest extends BaseRequestTest {
    * 1. Every consumer got assigned at least one partition
    * 2. Each partition is assigned to only one consumer
    * 3. Every partition is assigned to one of the consumers
+   * 4. The assignment is the same as expected assignment (if provided)

Review comment:
       Before the change, we don't verify the assignment results are the expected distribution. It's fine since we already tested that in each assignor tests. But here, I added a default assignor test, that I wanted to make sure it is using our expected assignor (i.e. Range assignor) to distribute the partitions. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org