[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378223401
 
 

 ##########
 File path: libminifi/include/core/state/nodes/AgentInformation.h
 ##########
 @@ -623,18 +632,70 @@ class AgentManifest : public DeviceInformation {
 };
 
 /**
- * Purpose and Justification: Prints classes along with their properties for the current agent.
+ * This class is used for regular heartbeat without manifest
+ * A light weight heartbeat
  */
-class AgentInformation : public DeviceInformation, public AgentMonitor, public AgentIdentifier {
+class AgentInformationWithoutManifest : public DeviceInformation, public AgentMonitor, public AgentIdentifier {
+public:
+
+    AgentInformationWithoutManifest(std::string name, utils::Identifier & uuid)
+    : DeviceInformation(name, uuid) {
 
 Review comment:
   Constructor initializer list should be indented +4 spaces to the right.
   
   Use `std::move(name)` to avoid unnecessary copying of `name`, since `DeviceInformation` takes it by-value, too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services