You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gilles (JIRA)" <ji...@apache.org> on 2011/02/16 14:33:57 UTC
[jira] Created: (MATH-513) Moving the "ParametricRealFunction"
interface
Moving the "ParametricRealFunction" interface
---------------------------------------------
Key: MATH-513
URL: https://issues.apache.org/jira/browse/MATH-513
Project: Commons Math
Issue Type: Improvement
Reporter: Gilles
Assignee: Gilles
Priority: Minor
Fix For: 3.0
I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MATH-513) Moving the "ParametricRealFunction"
interface
Posted by "Ole Ersoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Ersoy updated MATH-513:
---------------------------
Attachment: CurveFitter.patch
> Moving the "ParametricRealFunction" interface
> ---------------------------------------------
>
> Key: MATH-513
> URL: https://issues.apache.org/jira/browse/MATH-513
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
> Attachments: CurveFitter.patch, HarmonicFitter.patch, ParametricRealFunction.patch
>
>
> I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MATH-513) Moving the "ParametricRealFunction"
interface
Posted by "Ole Ersoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995508#comment-12995508 ]
Ole Ersoy commented on MATH-513:
--------------------------------
The ParametricGaussianFunction.patch can be ignored.
The ParametricGaussianFunction is being replaced by Gaussian.Parametric
So ParametricGaussianFunction could be deleted all together...unless
support for the four parameter "Pseudo" Gaussian is of interest...
> Moving the "ParametricRealFunction" interface
> ---------------------------------------------
>
> Key: MATH-513
> URL: https://issues.apache.org/jira/browse/MATH-513
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
> Attachments: CurveFitter.patch, Gaussian.patch, HarmonicFitter.patch, ParametricGaussianFunction.patch, ParametricRealFunction.patch, PolynomialFitter.patch
>
>
> I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MATH-513) Moving the "ParametricRealFunction"
interface
Posted by "Ole Ersoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Ersoy updated MATH-513:
---------------------------
Attachment: ParametricRealFunction.patch
> Moving the "ParametricRealFunction" interface
> ---------------------------------------------
>
> Key: MATH-513
> URL: https://issues.apache.org/jira/browse/MATH-513
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
> Attachments: ParametricRealFunction.patch
>
>
> I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MATH-513) Moving the "ParametricRealFunction"
interface
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995556#comment-12995556 ]
Gilles commented on MATH-513:
-----------------------------
Ole,
Thanks for trying to help with the patches but for either small changes (e.g. package name) or files that are already modified on my local copy (e.g. "Gaussian.java"), it is easier for me to do the changes directly instead of applying the patches...
Once I have committed the changes for this issue and for issue MATH-514, you can then send the patch for issue MATH-512, _if_ nobody objects to the dropping of fitting the constant in the "GaussianFitter". Assuming so, it would then also require modifications of the unit tests.
> Moving the "ParametricRealFunction" interface
> ---------------------------------------------
>
> Key: MATH-513
> URL: https://issues.apache.org/jira/browse/MATH-513
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
> Attachments: CurveFitter.patch, Gaussian.patch, HarmonicFitter.patch, ParametricGaussianFunction.patch, ParametricRealFunction.patch, PolynomialFitter.patch
>
>
> I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MATH-513) Moving the "ParametricRealFunction"
interface
Posted by "Ole Ersoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Ersoy updated MATH-513:
---------------------------
Attachment: Gaussian.patch
> Moving the "ParametricRealFunction" interface
> ---------------------------------------------
>
> Key: MATH-513
> URL: https://issues.apache.org/jira/browse/MATH-513
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
> Attachments: CurveFitter.patch, Gaussian.patch, HarmonicFitter.patch, ParametricGaussianFunction.patch, ParametricRealFunction.patch, PolynomialFitter.patch
>
>
> I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MATH-513) Moving the "ParametricRealFunction"
interface
Posted by "Luc Maisonobe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995328#comment-12995328 ]
Luc Maisonobe commented on MATH-513:
------------------------------------
This move seems good to me.
> Moving the "ParametricRealFunction" interface
> ---------------------------------------------
>
> Key: MATH-513
> URL: https://issues.apache.org/jira/browse/MATH-513
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
>
> I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (MATH-513) Moving the "ParametricRealFunction"
interface
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles resolved MATH-513.
-------------------------
Resolution: Fixed
Revision 1071429.
> Moving the "ParametricRealFunction" interface
> ---------------------------------------------
>
> Key: MATH-513
> URL: https://issues.apache.org/jira/browse/MATH-513
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
> Attachments: CurveFitter.patch, Gaussian.patch, HarmonicFitter.patch, ParametricGaussianFunction.patch, ParametricRealFunction.patch, PolynomialFitter.patch
>
>
> I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MATH-513) Moving the "ParametricRealFunction"
interface
Posted by "Ole Ersoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Ersoy updated MATH-513:
---------------------------
Attachment: ParametricGaussianFunction.patch
> Moving the "ParametricRealFunction" interface
> ---------------------------------------------
>
> Key: MATH-513
> URL: https://issues.apache.org/jira/browse/MATH-513
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
> Attachments: CurveFitter.patch, HarmonicFitter.patch, ParametricGaussianFunction.patch, ParametricRealFunction.patch, PolynomialFitter.patch
>
>
> I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MATH-513) Moving the "ParametricRealFunction"
interface
Posted by "Ole Ersoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Ersoy updated MATH-513:
---------------------------
Attachment: PolynomialFitter.patch
> Moving the "ParametricRealFunction" interface
> ---------------------------------------------
>
> Key: MATH-513
> URL: https://issues.apache.org/jira/browse/MATH-513
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
> Attachments: CurveFitter.patch, HarmonicFitter.patch, ParametricRealFunction.patch, PolynomialFitter.patch
>
>
> I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MATH-513) Moving the "ParametricRealFunction"
interface
Posted by "Ole Ersoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995631#comment-12995631 ]
Ole Ersoy commented on MATH-513:
--------------------------------
Gilles,
I guess I jumped the gun a little :). I already changed the tests as well and updated the GaussianFitter per the notes. I'll attach the patches to 512.
Here are some test notes:
The biggest differences in the for the change to the GaussianFitter (Now 3 parameters) can be seen in fit04 and fit05 (Poor data fits).
The last test in the ParametricGaussianFunction test fails. It was expecting a ZeroException, but now gets a NotStrictlyPositiveException...
> Moving the "ParametricRealFunction" interface
> ---------------------------------------------
>
> Key: MATH-513
> URL: https://issues.apache.org/jira/browse/MATH-513
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
> Attachments: CurveFitter.patch, Gaussian.patch, HarmonicFitter.patch, ParametricGaussianFunction.patch, ParametricRealFunction.patch, PolynomialFitter.patch
>
>
> I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MATH-513) Moving the "ParametricRealFunction"
interface
Posted by "Ole Ersoy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ole Ersoy updated MATH-513:
---------------------------
Attachment: HarmonicFitter.patch
> Moving the "ParametricRealFunction" interface
> ---------------------------------------------
>
> Key: MATH-513
> URL: https://issues.apache.org/jira/browse/MATH-513
> Project: Commons Math
> Issue Type: Improvement
> Reporter: Gilles
> Assignee: Gilles
> Priority: Minor
> Labels: api-change
> Fix For: 3.0
>
> Attachments: CurveFitter.patch, HarmonicFitter.patch, ParametricRealFunction.patch
>
>
> I'm suggesting that the "ParametricRealFunction" interface be moved from package "optimization.fitting" to the package "analysis" where other similar function interfaces (e.g. "UnivariateRealFunction" are defined). On the way it should also be renamed to "ParametricUnivariateRealFunction" (so as to allow the definition of the multivariate counterpart).
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira