You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/11/19 13:01:00 UTC

[jira] [Commented] (PROTON-1966) CompositeReadableBuffer#equals() can affect position for some content mismatches

    [ https://issues.apache.org/jira/browse/PROTON-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691671#comment-16691671 ] 

ASF subversion and git services commented on PROTON-1966:
---------------------------------------------------------

Commit ba9617831fb8c71c89473abfe2796e2e83f7003d in qpid-proton-j's branch refs/heads/master from [~gemmellr]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton-j.git;h=ba96178 ]

PROTON-1966: ensure the position is always reset on return


> CompositeReadableBuffer#equals() can affect position for some content mismatches
> --------------------------------------------------------------------------------
>
>                 Key: PROTON-1966
>                 URL: https://issues.apache.org/jira/browse/PROTON-1966
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-j
>    Affects Versions: proton-j-0.30.0
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Major
>             Fix For: proton-j-0.31.0
>
>
> CompositeReadableBuffer#equals() can affect position for some content mismatches. If the given ReadableBuffer has the same remaining content length as the buffer being operated on but differs within their content, the equals call can have side effect on the position.
> Credit to Francesco Nigro for spotting this (in his PR for PROTON-1965).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org