You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Richard Emberson (JIRA)" <ji...@apache.org> on 2011/03/03 17:23:37 UTC
[jira] Created: (WICKET-3499)
org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle
setResponse
org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle setResponse
-------------------------------------------------------------------------------------
Key: WICKET-3499
URL: https://issues.apache.org/jira/browse/WICKET-3499
Project: Wicket
Issue Type: Bug
Components: wicket-core
Affects Versions: 1.5-RC2
Environment: all
Reporter: Richard Emberson
Priority: Minor
In org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle is this
method correct:
public Response setResponse(Response response)
{
return response;
}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3499)
org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle
setResponse
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pedro Santos updated WICKET-3499:
---------------------------------
Attachment: WICKET-3499.patch
Fixed by copy/pasting the RequestHandlerStack#respond implementation from RequestCycle.HandlerExecutor, but now tests in RequestHandlerStackTest are meaningless since they are not testing the core code.
> org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle setResponse
> -------------------------------------------------------------------------------------
>
> Key: WICKET-3499
> URL: https://issues.apache.org/jira/browse/WICKET-3499
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC2
> Environment: all
> Reporter: Richard Emberson
> Priority: Minor
> Attachments: WICKET-3499.patch
>
>
> In org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle is this
> method correct:
>
> public Response setResponse(Response response)
> {
> return response;
> }
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WICKET-3499)
org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle
setResponse
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002529#comment-13002529 ]
Martin Grigorov commented on WICKET-3499:
-----------------------------------------
Yes, it seems we don't need this MockRequestCycle at all.
Currently some of the assertions (e.g. the one at line 126) tests that MockRequestCycle.setResponse(Response) does nothing.
> org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle setResponse
> -------------------------------------------------------------------------------------
>
> Key: WICKET-3499
> URL: https://issues.apache.org/jira/browse/WICKET-3499
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC2
> Environment: all
> Reporter: Richard Emberson
> Priority: Minor
> Attachments: WICKET-3499.patch
>
>
> In org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle is this
> method correct:
>
> public Response setResponse(Response response)
> {
> return response;
> }
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WICKET-3499)
org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle
setResponse
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3499.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC3
Assignee: Igor Vaynberg
applied pedro's patch with a small bugfix
> org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle setResponse
> -------------------------------------------------------------------------------------
>
> Key: WICKET-3499
> URL: https://issues.apache.org/jira/browse/WICKET-3499
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC2
> Environment: all
> Reporter: Richard Emberson
> Assignee: Igor Vaynberg
> Priority: Minor
> Fix For: 1.5-RC3
>
> Attachments: WICKET-3499.patch
>
>
> In org/apache/wicket/request/cycle/RequestCycleListenerTest MockRequestCycle is this
> method correct:
>
> public Response setResponse(Response response)
> {
> return response;
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira