[GitHub] [calcite] hannerwang commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

[GitBox <gi...@apache.org>]

hannerwang commented on code in PR #2838:
URL: https://github.com/apache/calcite/pull/2838#discussion_r903584538


##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander {
           SqlIdentifier sid = (SqlIdentifier) expr;
           final SqlIdentifier fqId = getScope().fullyQualify(sid).identifier;
           expr = expandDynamicStar(sid, fqId);
+        } else {
+          requireNonNull(expr, "expr");

Review Comment:
   Thanks ruben, I dove into SqlNodeList which is type of selectList and found its item could be nullable, but I couldn't found any possible nullable selectItem in parser.jj, so I think selectItem must be non-nullable, do you think so?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org