You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "merlimat (via GitHub)" <gi...@apache.org> on 2026/03/20 21:48:05 UTC
[PR] [fix][test] Fix flaky ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer [pulsar]
merlimat opened a new pull request, #25378:
URL: https://github.com/apache/pulsar/pull/25378
## Flaky test failure
```
org.awaitility.core.ConditionTimeoutException: Assertion condition expected [true] but found [false] within 10 seconds.
at org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer(ExtensibleLoadManagerImplTest.java:1324)
```
## Summary
- Fix flaky `ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer` by making it deterministic instead of time-dependent.
- The test updates the `loadBalancerServiceUnitTableViewSyncer` dynamic config and immediately triggers leader transitions. If the config hasn't propagated to the broker's `ServiceConfiguration` by the time the leader callback fires, `isLoadBalancerServiceUnitTableViewSyncerEnabled()` returns false and the syncer is never activated — causing the 10s Awaitility timeout to expire.
- Fix by explicitly waiting for the dynamic config to propagate to both brokers (by polling `isLoadBalancerServiceUnitTableViewSyncerEnabled()`) before triggering leader transitions. This ensures the leader callback sees the updated config and activates the syncer deterministically.
- Apply the same pattern to the cleanup section where the config is deleted.
## Documentation
- [x] `doc-not-needed`
(Your PR doesn't need any doc update)
## Matching PR in forked repository
_No response_
### Tip
Add the labels `ready-to-test` and `area/test` to trigger the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix flaky ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25378:
URL: https://github.com/apache/pulsar/pull/25378#issuecomment-4101411100
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/25378?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 72.70%. Comparing base ([`a3ae705`](https://app.codecov.io/gh/apache/pulsar/commit/a3ae70545f3aef40e8f5cfcced907e6500b08894?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ac62d51`](https://app.codecov.io/gh/apache/pulsar/commit/ac62d511ce12dd89ab08a69fdca4ed0a805c1a66?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/25378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #25378 +/- ##
============================================
+ Coverage 72.52% 72.70% +0.18%
+ Complexity 34275 33852 -423
============================================
Files 1927 1954 +27
Lines 154339 154791 +452
Branches 17683 17730 +47
============================================
+ Hits 111935 112544 +609
+ Misses 33389 33208 -181
- Partials 9015 9039 +24
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/25378/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/25378/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `25.76% <ø> (-0.28%)` | :arrow_down: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/25378/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `22.56% <ø> (?)` | |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/25378/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.67% <ø> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 168 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/25378/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][test] Fix flaky ExtensibleLoadManagerImplTest.testLoadBalancerServiceUnitTableViewSyncer [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #25378:
URL: https://github.com/apache/pulsar/pull/25378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org