You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "buptxxb65 (via GitHub)" <gi...@apache.org> on 2023/04/12 06:51:39 UTC

[GitHub] [rocketmq] buptxxb65 commented on a diff in pull request #6417: [ISSUE #6205] Support Async pull for DefaultLitePullConsumer

buptxxb65 commented on code in PR #6417:
URL: https://github.com/apache/rocketmq/pull/6417#discussion_r1163697466


##########
example/src/main/java/org/apache/rocketmq/example/simple/LitePullConsumerAsync.java:
##########
@@ -0,0 +1,42 @@
+package org.apache.rocketmq.example.simple;

Review Comment:
   Yes, I totally agree with you so I'll remove this example tonight. And I want to make sure my understanding is correct. 
   
   Since we haven't figure out a suitable way to start an Async pull, we can only change the constructor method of PullTaskImpl in seek(). Therefore, in users' view (example view), they just call the seek() function. Maybe we can add a new example after we separate the Async pull and Sync pull.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org