You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/10 01:53:09 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #29702: [SPARK-32832][SS] Use CaseInsensitiveMap for DataStreamReader/Writer options
cloud-fan commented on a change in pull request #29702:
URL: https://github.com/apache/spark/pull/29702#discussion_r486015652
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
##########
@@ -535,5 +536,5 @@ final class DataStreamReader private[sql](sparkSession: SparkSession) extends Lo
private var userSpecifiedSchema: Option[StructType] = None
- private var extraOptions = new scala.collection.mutable.HashMap[String, String]
+ private var extraOptions = CaseInsensitiveMap[String](Map.empty)
Review comment:
`DataStreamReader` support reading DS v2, shall we get the original map at that place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org