You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/04/05 01:55:55 UTC

Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45717/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-5113
    https://issues.apache.org/jira/browse/MESOS-5113


Repository: mesos


Description
-------

`rootDir` and `pluginDir` can be `None` in case the operator does not
specify the network cni flags. In this case invoking `recover` on the
isolator without checking the `rootDir` and `pluginDir` for `isSome`
will cause the Agent to crash.


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621 

Diff: https://reviews.apache.org/r/45717/diff/


Testing
-------

make

Bought a slave and master and verified that the slave does not crash.


Thanks,

Avinash sridharan

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

Posted by Avinash sridharan <av...@mesosphere.io>.

> On April 5, 2016, 12:29 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 325
> > <https://reviews.apache.org/r/45717/diff/1/?file=1325272#file1325272line325>
> >
> >     Do we need to check `pluginDir` here? I think in `recover()`, `pluginDir` will not be used, it should only be used in `attach` and `detach`. And in another hand, `rootDir` and `pluginDir` are always both set or both not set, it is not possible that we have one set but another not set, so I think checking one (`rootDir`) should be enough.

I guess we can simplify this check. Have gone ahead and removed check on `pluginDir`.


- Avinash


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45717/#review126991
-----------------------------------------------------------


On April 4, 2016, 11:55 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45717/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 11:55 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5113
>     https://issues.apache.org/jira/browse/MESOS-5113
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `rootDir` and `pluginDir` can be `None` in case the operator does not
> specify the network cni flags. In this case invoking `recover` on the
> isolator without checking the `rootDir` and `pluginDir` for `isSome`
> will cause the Agent to crash.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621 
> 
> Diff: https://reviews.apache.org/r/45717/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> Bought a slave and master and verified that the slave does not crash.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45717/#review126991
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 325)
<https://reviews.apache.org/r/45717/#comment190123>

    Do we need to check `pluginDir` here? I think in `recover()`, `pluginDir` will not be used, it should only be used in `attach` and `detach`. And in another hand, `rootDir` and `pluginDir` are always both set or both not set, it is not possible that we have one set but another not set, so I think checking one (`rootDir`) should be enough.


- Qian Zhang


On April 5, 2016, 7:55 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45717/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 7:55 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5113
>     https://issues.apache.org/jira/browse/MESOS-5113
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `rootDir` and `pluginDir` can be `None` in case the operator does not
> specify the network cni flags. In this case invoking `recover` on the
> isolator without checking the `rootDir` and `pluginDir` for `isSome`
> will cause the Agent to crash.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621 
> 
> Diff: https://reviews.apache.org/r/45717/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> Bought a slave and master and verified that the slave does not crash.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45717/#review127020
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45717]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 4, 2016, 11:55 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45717/
> -----------------------------------------------------------
> 
> (Updated April 4, 2016, 11:55 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5113
>     https://issues.apache.org/jira/browse/MESOS-5113
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `rootDir` and `pluginDir` can be `None` in case the operator does not
> specify the network cni flags. In this case invoking `recover` on the
> isolator without checking the `rootDir` and `pluginDir` for `isSome`
> will cause the Agent to crash.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621 
> 
> Diff: https://reviews.apache.org/r/45717/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> Bought a slave and master and verified that the slave does not crash.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45717/#review127055
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On April 5, 2016, 2:19 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45717/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 2:19 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5113
>     https://issues.apache.org/jira/browse/MESOS-5113
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `rootDir` and `pluginDir` can be `None` in case the operator does not
> specify the network cni flags. In this case invoking `recover` on the
> isolator without checking the `rootDir` and `pluginDir` for `isSome`
> will cause the Agent to crash.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621 
> 
> Diff: https://reviews.apache.org/r/45717/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> Bought a slave and master and verified that the slave does not crash.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45717/#review127058
-----------------------------------------------------------



Patch looks great!

Reviews applied: [45717]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 5, 2016, 6:19 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45717/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 6:19 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5113
>     https://issues.apache.org/jira/browse/MESOS-5113
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `rootDir` and `pluginDir` can be `None` in case the operator does not
> specify the network cni flags. In this case invoking `recover` on the
> isolator without checking the `rootDir` and `pluginDir` for `isSome`
> will cause the Agent to crash.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621 
> 
> Diff: https://reviews.apache.org/r/45717/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> Bought a slave and master and verified that the slave does not crash.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45717/#review127149
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On April 5, 2016, 6:19 a.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45717/
> -----------------------------------------------------------
> 
> (Updated April 5, 2016, 6:19 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5113
>     https://issues.apache.org/jira/browse/MESOS-5113
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `rootDir` and `pluginDir` can be `None` in case the operator does not
> specify the network cni flags. In this case invoking `recover` on the
> isolator without checking the `rootDir` and `pluginDir` for `isSome`
> will cause the Agent to crash.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621 
> 
> Diff: https://reviews.apache.org/r/45717/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> Bought a slave and master and verified that the slave does not crash.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 45717: Added checks to verify that `rootDir` and `pluginDir` `isSome.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45717/
-----------------------------------------------------------

(Updated April 5, 2016, 6:19 a.m.)


Review request for mesos, Jie Yu and Qian Zhang.


Changes
-------

Addressed comments.


Bugs: MESOS-5113
    https://issues.apache.org/jira/browse/MESOS-5113


Repository: mesos


Description
-------

`rootDir` and `pluginDir` can be `None` in case the operator does not
specify the network cni flags. In this case invoking `recover` on the
isolator without checking the `rootDir` and `pluginDir` for `isSome`
will cause the Agent to crash.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp af5f49007e0afe57006c9db940611e56eb75a621 

Diff: https://reviews.apache.org/r/45717/diff/


Testing
-------

make

Bought a slave and master and verified that the slave does not crash.


Thanks,

Avinash sridharan