[GitHub] [flink] wsry opened a new pull request #9758: [FLINK-14185][tests]Move unstable assertion statement out of close method of QS test server.

[GitBox <gi...@apache.org>]

wsry opened a new pull request #9758: [FLINK-14185][tests]Move unstable assertion statement out of close method of QS test server.
URL: https://github.com/apache/flink/pull/9758
 
 
   ## What is the purpose of the change
   
   The purpose of this pr is to fix the unstable test case AbstractServerTest. The test case failed on Travis. The failure reason is that the requestStats is shared by two instance of TestServer which relies on AutoCloseable interface for connection release. If one of the server has been shut down and the anther is not, the assertion in the close method can fail. This pr fix the problem by moving the assertion out of the close method.
   
   
   ## Brief change log
   
     - The unstable assertion statement was moved out of the close method of TestServer.
   
   
   ## Verifying this change
   
   The change can be verified by the test case itself.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services