[GitHub] [iceberg] rdblue commented on a change in pull request #1189: Spark: Support ORC vectorized reads

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1189:
URL: https://github.com/apache/iceberg/pull/1189#discussion_r453120088



##########
File path: orc/src/main/java/org/apache/iceberg/orc/ORC.java
##########
@@ -177,9 +179,20 @@ public ReadBuilder filter(Expression newFilter) {
       return this;
     }
 
+    public ReadBuilder createBatchedReaderFunc(Function<TypeDescription, OrcBatchReader<?>> batchReaderFunction) {
+      this.batchedReaderFunc = batchReaderFunction;

Review comment:
       This should validate that `createReaderFunc` hasn't also been called. And that function should validate that this one hasn't been called. That way there is no ambiguous behavior and the user gets an error when they try to set up both batch and row readers.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org