You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by emres <gi...@git.apache.org> on 2015/02/13 21:06:48 UTC
[GitHub] spark pull request: SPARK-5805 Fixed the type error in documentati...
GitHub user emres opened a pull request:
https://github.com/apache/spark/pull/4596
SPARK-5805 Fixed the type error in documentation.
Fixes SPARK-5805 : Fix the type error in the final example given in MLlib - Clustering documentation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emres/spark SPARK-5805
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4596.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4596
----
commit 1029f66f6d85739d5f1ea429ea8ab0a389a2c0f8
Author: Emre Sevinç <em...@gmail.com>
Date: 2015-02-13T19:59:37Z
SPARK-5805 Fixed the type error in documentation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5805 Fixed the type error in documentati...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4596#issuecomment-74372238
@emres basically you would check out `branch-1.2`, make a new branch from there, make your change again (minus the change to GMM which won't exist), and then simply submit that PR like this one. You can note it's a backport.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5805 Fixed the type error in documentati...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/4596#issuecomment-74323195
Merged into master and branch-1.3 (skipped Jenkins because this only contains doc changes.)
@emres This PR contains changes to GMM. It won't be able to merge into branch-1.2. Could you send a patch to branch-1.2? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5805 Fixed the type error in documentati...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4596#issuecomment-74317920
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5805 Fixed the type error in documentati...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/4596#issuecomment-74319434
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5805 Fixed the type error in documentati...
Posted by emres <gi...@git.apache.org>.
Github user emres commented on the pull request:
https://github.com/apache/spark/pull/4596#issuecomment-74336280
I would gladly do that, but I'm not sure exactly how to send a patch to a
particular branch, e.g. branch-1.2
What I have done was simply to fork the original Spark repository, create a
new branch in my forked repository with the same name as JIRA issue number,
commit my change and just send a pull request via Github.
How can I send a patch to branch-1.2 after having done what I described
above?
--
Emre
On Fri, Feb 13, 2015 at 9:40 PM, Xiangrui Meng <no...@github.com>
wrote:
> Merged into master and branch-1.3 (skipped Jenkins because this only
> contains doc changes.)
>
> @emres <https://github.com/emres> This PR contains changes to GMM. It
> won't be able to merge into branch-1.2. Could you send a patch to
> branch-1.2? Thanks!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/4596#issuecomment-74323195>.
>
--
Emre Sevinc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5805 Fixed the type error in documentati...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4596
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-5805 Fixed the type error in documentati...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4596#issuecomment-74378389
Ah, BTW, the reason you had these merge conflicts is because your change actually modified a lot of lines trailing whitespace. Ideally we would have undone those and just committed your one-liner. Anyway, I can merge the new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org