You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/02/19 07:28:53 UTC
[GitHub] [james-project] Arsnael commented on a change in pull request #303: JAMES-3499 Use a module chooser for LDAP users repository
Arsnael commented on a change in pull request #303:
URL: https://github.com/apache/james-project/pull/303#discussion_r578979482
##########
File path: dockerfiles/compilation/java-11/compile.sh
##########
@@ -73,16 +73,16 @@ unzip $GLOW_ROOT_ZIP
if [ $? -eq 0 ]; then
if [ -d "$CASSANDRA_RABBITMQ_LDAP_DESTINATION" ]; then
echo "Copying cassandra - rabbitMQ - Ldap JARs"
- cp server/container/guice/cassandra-rabbitmq-ldap-guice/target/james-server-cassandra-rabbitmq-ldap-guice.jar $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
- cp -r server/container/guice/cassandra-rabbitmq-ldap-guice/target/james-server-cassandra-rabbitmq-ldap-guice.lib $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
+ cp server/container/guice/cassandra-rabbitmq-guice/target/james-server-cassandra-rabbitmq-guice.jar $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
+ cp -r server/container/guice/cassandra-rabbitmq-guice/target/james-server-cassandra-rabbitmq-guice.lib $CASSANDRA_RABBITMQ_LDAP_DESTINATION || true
Review comment:
I don't think you want to change that. Seeing that you are basing your module chooser on whether or not you have an ldap conf in usersrepository.xml, if you point the build towards the conf of `cassandra-rabbitmq-guice`, you will not end up with a ldap support server here. You will likely generate twice the same cassandra-rabbitmq-guice image here, right?
##########
File path: dockerfiles/compilation/java-11/compile.sh
##########
@@ -98,8 +98,8 @@ if [ $? -eq 0 ]; then
cp server/container/cli/target/james-server-cli.jar $CASSANDRA_DESTINATION || true
cp -r server/container/cli/target/james-server-cli.lib $CASSANDRA_DESTINATION || true
- cp server/container/guice/cassandra-ldap-guice/target/james-server-cassandra-ldap-guice.jar $CASSANDRA_DESTINATION || true
- cp -r server/container/guice/cassandra-ldap-guice/target/james-server-cassandra-ldap-guice.lib $CASSANDRA_DESTINATION || true
+ cp server/container/guice/cassandra-guice/target/james-server-cassandra-guice.jar $CASSANDRA_DESTINATION || true
+ cp -r server/container/guice/cassandra-guice/target/james-server-cassandra-guice.lib $CASSANDRA_DESTINATION || true
Review comment:
idem as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org