You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2022/04/07 10:28:59 UTC

[GitHub] [celix] PengZheng opened a new pull request, #411: Unify conan autogenerated find modules with Celix's own find modules.

PengZheng opened a new pull request, #411:
URL: https://github.com/apache/celix/pull/411

   Unify all remaining find modules mentioned in #409, fix missing updates for CelixConfig.cmake.
   A gcc warning is also eliminated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [celix] PengZheng commented on pull request #411: Unify conan autogenerated find modules with Celix's own find modules.

Posted by GitBox <gi...@apache.org>.
PengZheng commented on PR #411:
URL: https://github.com/apache/celix/pull/411#issuecomment-1093619459

   I'll merge it now to fix broken conan package. If there is any issue, please leave a comment. 
   I'll fix any issue asap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [celix] codecov-commenter commented on pull request #411: Unify conan autogenerated find modules with Celix's own find modules.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #411:
URL: https://github.com/apache/celix/pull/411#issuecomment-1091545668

   # [Codecov](https://codecov.io/gh/apache/celix/pull/411?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#411](https://codecov.io/gh/apache/celix/pull/411?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d608c59) into [master](https://codecov.io/gh/apache/celix/commit/91fff325e328b3b2485940d128f5664cf60342a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91fff32) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head d608c59 differs from pull request most recent head a7412f9. Consider uploading reports for the commit a7412f9 to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #411      +/-   ##
   ==========================================
   + Coverage   71.77%   71.78%   +0.01%     
   ==========================================
     Files         180      180              
     Lines       29287    29287              
   ==========================================
   + Hits        21022    21025       +3     
   + Misses       8265     8262       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/celix/pull/411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sub/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/411/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19zZW5kZXIuYw==) | `85.65% <0.00%> (+1.26%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/411?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/411?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [91fff32...a7412f9](https://codecov.io/gh/apache/celix/pull/411?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [celix] PengZheng merged pull request #411: Unify conan autogenerated find modules with Celix's own find modules.

Posted by GitBox <gi...@apache.org>.
PengZheng merged PR #411:
URL: https://github.com/apache/celix/pull/411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org