You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/10 03:03:39 UTC
[GitHub] [doris] Yukang-Lian opened a new pull request, #14141: [Feature](function) Support array_compact function
Yukang-Lian opened a new pull request, #14141:
URL: https://github.com/apache/doris/pull/14141
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on a diff in pull request #14141: [Feature](function) Support array_compact function
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on code in PR #14141:
URL: https://github.com/apache/doris/pull/14141#discussion_r1021493028
##########
be/src/vec/functions/array/function_array_compact.h:
##########
@@ -0,0 +1,180 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+
+namespace doris::vectorized {
+
+class FunctionArrayCompact : public IFunction {
+public:
+ static constexpr auto name = "array_compact";
+ static FunctionPtr create() { return std::make_shared<FunctionArrayCompact>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ auto& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets64& src_offsets,
Review Comment:
what's the difference of `_execute_number` and `_execute_generic `?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #14141: [Feature](function) Support array_compact function
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on PR #14141:
URL: https://github.com/apache/doris/pull/14141#issuecomment-1312941702
please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on a diff in pull request #14141: [Feature](function) Support array_compact function
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on code in PR #14141:
URL: https://github.com/apache/doris/pull/14141#discussion_r1018992323
##########
be/src/vec/functions/array/function_array_compact.h:
##########
@@ -0,0 +1,251 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+
+namespace doris::vectorized {
+
+class FunctionArrayCompact : public IFunction {
+public:
+ static constexpr auto name = "array_compact";
+ static FunctionPtr create() { return std::make_shared<FunctionArrayCompact>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ auto& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets64& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets64& dest_offsets,
Review Comment:
why not we just use `ColumnArray's nested column` as input arguments, and then we could ignore nullable situation, the code is more like
```
++src_pos;
++res_pos;
for (; src_pos < src_offset; ++src_pos) {
if (nested_src->compareAt(src_pos - 1, src_pos, *nested_src, 1)) {
nested_dst_column->insert_from(src_values, src_pos);
++res_pos;
}
}
```
if `nested_dst_column` and `nested_src` is nullable, then insert_from will handle whether the value is null or not automatically， so you won't need to take care of the null values
##########
be/src/vec/functions/array/function_array_compact.h:
##########
@@ -0,0 +1,251 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+
+namespace doris::vectorized {
+
+class FunctionArrayCompact : public IFunction {
+public:
+ static constexpr auto name = "array_compact";
+ static FunctionPtr create() { return std::make_shared<FunctionArrayCompact>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ auto& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets64& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets64& dest_offsets,
Review Comment:
the code could be more clean and clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #14141: [Feature](function) Support array_compact function
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on PR #14141:
URL: https://github.com/apache/doris/pull/14141#issuecomment-1314655258
need rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on a diff in pull request #14141: [Feature](function) Support array_compact function
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on code in PR #14141:
URL: https://github.com/apache/doris/pull/14141#discussion_r1018820539
##########
be/src/vec/functions/array/function_array_compact.h:
##########
@@ -0,0 +1,278 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+
+namespace doris::vectorized {
+
+class FunctionArrayCompact : public IFunction {
+public:
+ static constexpr auto name = "array_compact";
+ static FunctionPtr create() { return std::make_shared<FunctionArrayCompact>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ auto& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets64& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets64& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset64 src_offsets_size = src_offsets.size();
+ ColumnArray::Offset64 src_pos = 0;
+ ColumnArray::Offset64 dest_pos = 0;
+
+ for (size_t i = 0; i < src_offsets_size; ++i) {
+ auto src_offset = src_offsets[i];
+ if (src_pos < src_offset) {
+ // Insert first element
+ if (src_null_map && (*src_null_map)[src_pos]) {
+ DCHECK(dest_null_map != nullptr);
+ (*dest_null_map).push_back(true);
+ dest_datas.push_back(NestType());
+ } else {
+ dest_datas.push_back(src_datas[src_pos]);
+ if (dest_null_map) {
+ (*dest_null_map).push_back(false);
+ }
+ }
+ ++src_pos;
+ ++dest_pos;
+
+ // For the rest of elements, insert if the element is different from the previous.
+ for (; src_pos < src_offset; ++src_pos) {
+ if (src_null_map && (*src_null_map)[src_pos] &&
+ !((*src_null_map)[src_pos - 1])) {
+ DCHECK(dest_null_map != nullptr);
+ (*dest_null_map).push_back(true);
+ dest_datas.push_back(NestType());
+ ++dest_pos;
+ } else if (0 != (src_data_concrete->compare_at(src_pos - 1, src_pos, src_column,
+ 1))) {
+ dest_datas.push_back(src_datas[src_pos]);
+ if (dest_null_map) {
+ (*dest_null_map).push_back(false);
+ }
+ ++dest_pos;
+ }
+ }
+ }
+ dest_offsets.push_back(dest_pos);
+ }
+ return true;
+ }
+
+ bool _execute_string(const IColumn& src_column, const ColumnArray::Offsets64& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets64& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ const ColumnString* src_data_concrete = reinterpret_cast<const ColumnString*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
Review Comment:
we could use this more generic function to handle cases which contain more complex types like `ARRAY<ARRAY<STRING>>`, et...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14141: [Feature](function) Support array_compact function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14141:
URL: https://github.com/apache/doris/pull/14141#issuecomment-1314826593
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Yukang-Lian commented on a diff in pull request #14141: [Feature](function) Support array_compact function
Posted by GitBox <gi...@apache.org>.
Yukang-Lian commented on code in PR #14141:
URL: https://github.com/apache/doris/pull/14141#discussion_r1019012981
##########
be/src/vec/functions/array/function_array_compact.h:
##########
@@ -0,0 +1,251 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+
+namespace doris::vectorized {
+
+class FunctionArrayCompact : public IFunction {
+public:
+ static constexpr auto name = "array_compact";
+ static FunctionPtr create() { return std::make_shared<FunctionArrayCompact>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ auto& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets64& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets64& dest_offsets,
Review Comment:
Yeah, you are right and I will refactor this part of the code soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on a diff in pull request #14141: [Feature](function) Support array_compact function
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on code in PR #14141:
URL: https://github.com/apache/doris/pull/14141#discussion_r1018884978
##########
docs/en/docs/sql-manual/sql-functions/array-functions/array_compact.md:
##########
@@ -0,0 +1,81 @@
+---
+{
+ "title": "array_compact",
+ "language": "en"
+}
+---
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+ http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+## array_compact
+
+### description
+
+Removes consecutive duplicate elements from an array. The order of result values is determined by the order in the source array.
+
+#### Syntax
+
+```sql
+array_compact(arr)
+```
+
+#### Arguments
+
+`arr` — The array to inspect.
+
+#### Returned value
+
+The array without duplicate.
Review Comment:
The array without **continuous** duplicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #14141: [Feature](function) Support array_compact function
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #14141:
URL: https://github.com/apache/doris/pull/14141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14141: [Feature](function) Support array_compact function
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14141:
URL: https://github.com/apache/doris/pull/14141#issuecomment-1309744812
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.94 seconds
load time: 452 seconds
storage size: 17180344230 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221110041315_clickbench_pr_43100.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] eldenmoon commented on a diff in pull request #14141: [Feature](function) Support array_compact function
Posted by GitBox <gi...@apache.org>.
eldenmoon commented on code in PR #14141:
URL: https://github.com/apache/doris/pull/14141#discussion_r1018817844
##########
be/src/vec/functions/array/function_array_compact.h:
##########
@@ -0,0 +1,278 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+
+namespace doris::vectorized {
+
+class FunctionArrayCompact : public IFunction {
+public:
+ static constexpr auto name = "array_compact";
+ static FunctionPtr create() { return std::make_shared<FunctionArrayCompact>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ /// Get function name.
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 1; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const override {
+ DCHECK(is_array(arguments[0]))
+ << "first argument for function: " << name << " should be DataTypeArray"
+ << " and arguments[0] is " << arguments[0]->get_name();
+ return arguments[0];
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) override {
+ ColumnPtr src_column =
+ block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& src_column_array = check_and_get_column<ColumnArray>(*src_column);
+ if (!src_column_array) {
+ return Status::RuntimeError(
+ fmt::format("unsupported types for function {}({})", get_name(),
+ block.get_by_position(arguments[0]).type->get_name()));
+ }
+ const auto& src_offsets = src_column_array->get_offsets();
+ const auto* src_nested_column = &src_column_array->get_data();
+ DCHECK(src_nested_column != nullptr);
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto nested_type = assert_cast<const DataTypeArray&>(*src_column_type).get_nested_type();
+ auto dest_column_ptr = ColumnArray::create(nested_type->create_column(),
+ ColumnArray::ColumnOffsets::create());
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ auto& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+
+ const NullMapType* src_null_map = nullptr;
+ if (src_nested_column->is_nullable()) {
+ const ColumnNullable* src_nested_nullable_col =
+ check_and_get_column<ColumnNullable>(*src_nested_column);
+ src_nested_column = src_nested_nullable_col->get_nested_column_ptr();
+ src_null_map = &src_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ NullMapType* dest_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
+ ColumnNullable* dest_nested_nullable_col =
+ reinterpret_cast<ColumnNullable*>(dest_nested_column);
+ dest_nested_column = dest_nested_nullable_col->get_nested_column_ptr();
+ dest_null_map = &dest_nested_nullable_col->get_null_map_column().get_data();
+ }
+
+ auto res_val = _execute_by_type(*src_nested_column, src_offsets, *dest_nested_column,
+ dest_offsets, src_null_map, dest_null_map, nested_type);
+ if (!res_val) {
+ return Status::RuntimeError(
+ fmt::format("execute failed or unsupported types for function {}({})",
+ get_name(), block.get_by_position(arguments[0]).type->get_name()));
+ }
+
+ block.replace_by_position(result, std::move(dest_column_ptr));
+ return Status::OK();
+ }
+
+private:
+ template <typename ColumnType>
+ bool _execute_number(const IColumn& src_column, const ColumnArray::Offsets64& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets64& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ using NestType = typename ColumnType::value_type;
+ const ColumnType* src_data_concrete = reinterpret_cast<const ColumnType*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
+ const PaddedPODArray<NestType>& src_datas = src_data_concrete->get_data();
+
+ ColumnType& dest_data_concrete = reinterpret_cast<ColumnType&>(dest_column);
+ PaddedPODArray<NestType>& dest_datas = dest_data_concrete.get_data();
+
+ ColumnArray::Offset64 src_offsets_size = src_offsets.size();
+ ColumnArray::Offset64 src_pos = 0;
+ ColumnArray::Offset64 dest_pos = 0;
+
+ for (size_t i = 0; i < src_offsets_size; ++i) {
+ auto src_offset = src_offsets[i];
+ if (src_pos < src_offset) {
+ // Insert first element
+ if (src_null_map && (*src_null_map)[src_pos]) {
+ DCHECK(dest_null_map != nullptr);
+ (*dest_null_map).push_back(true);
+ dest_datas.push_back(NestType());
+ } else {
+ dest_datas.push_back(src_datas[src_pos]);
+ if (dest_null_map) {
+ (*dest_null_map).push_back(false);
+ }
+ }
+ ++src_pos;
+ ++dest_pos;
+
+ // For the rest of elements, insert if the element is different from the previous.
+ for (; src_pos < src_offset; ++src_pos) {
+ if (src_null_map && (*src_null_map)[src_pos] &&
+ !((*src_null_map)[src_pos - 1])) {
+ DCHECK(dest_null_map != nullptr);
+ (*dest_null_map).push_back(true);
+ dest_datas.push_back(NestType());
+ ++dest_pos;
+ } else if (0 != (src_data_concrete->compare_at(src_pos - 1, src_pos, src_column,
+ 1))) {
+ dest_datas.push_back(src_datas[src_pos]);
+ if (dest_null_map) {
+ (*dest_null_map).push_back(false);
+ }
+ ++dest_pos;
+ }
+ }
+ }
+ dest_offsets.push_back(dest_pos);
+ }
+ return true;
+ }
+
+ bool _execute_string(const IColumn& src_column, const ColumnArray::Offsets64& src_offsets,
+ IColumn& dest_column, ColumnArray::Offsets64& dest_offsets,
+ const NullMapType* src_null_map, NullMapType* dest_null_map) {
+ const ColumnString* src_data_concrete = reinterpret_cast<const ColumnString*>(&src_column);
+ if (!src_data_concrete) {
+ return false;
+ }
Review Comment:
`_execute_string` may be implemented more `generic`, for eg. using function like `insert_from` instead of memcpy, in this way, this function could reduce more code used for handing `nullable` cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org