You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by "Sloane, Brandon" <bs...@tresys.com> on 2019/05/20 15:23:37 UTC
New commit to enumeration PR
I know that this PR has already been reviewed, but when I rebased it back onto the latest version of master, I discovered that it exposed a regression in master.
There is now a second commit in the PR to fix this. Assuming no one objects, I can squash this into the main enumerations commit.
Brandon T. Sloane
Associate, Services
bsloane@tresys.com | tresys.com
Re: New commit to enumeration PR
Posted by Steve Lawrence <st...@gmail.com>.
Looks good to me
On Mon, May 20, 2019, 8:27 AM Beckerle, Mike <mb...@tresys.com> wrote:
> No objections from me.
>
> ________________________________
> From: Sloane, Brandon <bs...@tresys.com>
> Sent: Monday, May 20, 2019 11:23:37 AM
> To: dev@daffodil.apache.org
> Subject: New commit to enumeration PR
>
> I know that this PR has already been reviewed, but when I rebased it back
> onto the latest version of master, I discovered that it exposed a
> regression in master.
>
>
> There is now a second commit in the PR to fix this. Assuming no one
> objects, I can squash this into the main enumerations commit.
>
>
> Brandon T. Sloane
>
> Associate, Services
>
> bsloane@tresys.com | tresys.com
>
Re: New commit to enumeration PR
Posted by "Beckerle, Mike" <mb...@tresys.com>.
No objections from me.
________________________________
From: Sloane, Brandon <bs...@tresys.com>
Sent: Monday, May 20, 2019 11:23:37 AM
To: dev@daffodil.apache.org
Subject: New commit to enumeration PR
I know that this PR has already been reviewed, but when I rebased it back onto the latest version of master, I discovered that it exposed a regression in master.
There is now a second commit in the PR to fix this. Assuming no one objects, I can squash this into the main enumerations commit.
Brandon T. Sloane
Associate, Services
bsloane@tresys.com | tresys.com