You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/09/20 02:39:20 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43002: [SPARK-43498][PS][TESTS] Enable `StatsTests.test_axis_on_dataframe` for pandas 2.0.0.

dongjoon-hyun commented on code in PR #43002:
URL: https://github.com/apache/spark/pull/43002#discussion_r1330893931


##########
python/pyspark/pandas/tests/test_stats.py:
##########
@@ -180,6 +176,10 @@ def test_axis_on_dataframe(self):
                 },
                 index=range(10, 15001, 10),
             )
+            # There is a regression in Pandas 2.1.0,
+            # so we should manually cast to float until the regression is fixed.
+            # See https://github.com/pandas-dev/pandas/issues/55194.
+            pdf = pdf.astype(float)

Review Comment:
   If this is a `Pandas` bug, it seems that we need another TODO Spark JIRA ID to clean up this after Pandas community fixes it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org