You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "abstractdog (via GitHub)" <gi...@apache.org> on 2025/09/22 15:56:18 UTC
[PR] TEZ-4650: Remove useless logic from AM plugin management: processSchedulerDescriptors [tez]
abstractdog opened a new pull request, #433:
URL: https://github.com/apache/tez/pull/433
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4650: Remove useless logic from AM plugin management: processSchedulerDescriptors [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #433:
URL: https://github.com/apache/tez/pull/433#issuecomment-3320235264
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 32m 55s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 1s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 27s | | master passed |
| +1 :green_heart: | compile | 0m 56s | | master passed |
| +1 :green_heart: | checkstyle | 1m 8s | | master passed |
| +1 :green_heart: | javadoc | 0m 35s | | master passed |
| +0 :ok: | spotbugs | 2m 43s | | tez-dag in master has 785 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 36s | | the patch passed |
| +1 :green_heart: | codespell | 0m 44s | | No new issues. |
| +1 :green_heart: | compile | 0m 38s | | the patch passed |
| +1 :green_heart: | javac | 0m 38s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 21s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 16s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 9s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 5m 28s | [/patch-unit-tez-dag.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/2/artifact/out/patch-unit-tez-dag.txt) | tez-dag in the patch passed. |
| +1 :green_heart: | asflicense | 0m 15s | | The patch does not generate ASF License warnings. |
| | | 63m 39s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | tez.dag.app.TestDAGAppMaster |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/433 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile |
| uname | Linux dd123031ee13 5.15.0-151-generic #161-Ubuntu SMP Tue Jul 22 14:25:40 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-433/src/.yetus/personality.sh |
| git revision | master / 10f2d449c8017a7d549e386cce3203ca871ee7db |
| Default Java | Ubuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/2/testReport/ |
| Max. process+thread count | 218 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/2/console |
| versions | git=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4650: Remove useless logic from AM plugin management: processSchedulerDescriptors [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog merged PR #433:
URL: https://github.com/apache/tez/pull/433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4650: Remove useless logic from AM plugin management: processSchedulerDescriptors [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #433:
URL: https://github.com/apache/tez/pull/433#issuecomment-3320167208
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 27m 40s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 47s | | master passed |
| +1 :green_heart: | compile | 0m 45s | | master passed |
| +1 :green_heart: | checkstyle | 1m 6s | | master passed |
| +1 :green_heart: | javadoc | 0m 36s | | master passed |
| +0 :ok: | spotbugs | 2m 33s | | tez-dag in master has 785 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 33s | | the patch passed |
| +1 :green_heart: | codespell | 0m 32s | | No new issues. |
| +1 :green_heart: | compile | 0m 33s | | the patch passed |
| +1 :green_heart: | javac | 0m 33s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 18s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 13s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 52s | | the patch passed |
|||| _ Other Tests _ |
| -1 :x: | unit | 5m 6s | [/patch-unit-tez-dag.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/1/artifact/out/patch-unit-tez-dag.txt) | tez-dag in the patch passed. |
| +1 :green_heart: | asflicense | 0m 13s | | The patch does not generate ASF License warnings. |
| | | 55m 4s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | tez.dag.app.TestDAGAppMaster |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/433 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile |
| uname | Linux 19305c516537 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-433/src/.yetus/personality.sh |
| git revision | master / 10f2d449c8017a7d549e386cce3203ca871ee7db |
| Default Java | Ubuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/1/testReport/ |
| Max. process+thread count | 243 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/1/console |
| versions | git=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4650: Remove useless logic from AM plugin management: processSchedulerDescriptors [tez]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on PR #433:
URL: https://github.com/apache/tez/pull/433#issuecomment-3322575188
apparently, there is a failing case:
```
[ERROR] TestDAGAppMaster.testParseAllPluginsOnlyCustomSpecified:275->verifyDescAndMap:413 expected:<2> but was:<1>
```
I'm going to investigate this: it seems like this unit tests asserts that the yarn plugin descriptor is hacked to the entities even when enableYarn:false, so the application expects it to be present in non-local mode, even when containersEnabled=false...which still seems quite hacky, need to understand what usecase this unit test covers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4650: Remove useless logic from AM plugin management: processSchedulerDescriptors [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #433:
URL: https://github.com/apache/tez/pull/433#issuecomment-3352625086
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 39s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 49s | | master passed |
| +1 :green_heart: | compile | 0m 47s | | master passed |
| +1 :green_heart: | checkstyle | 1m 19s | | master passed |
| +1 :green_heart: | javadoc | 0m 37s | | master passed |
| +0 :ok: | spotbugs | 2m 35s | | tez-dag in master has 785 extant spotbugs warnings. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 31s | | the patch passed |
| +1 :green_heart: | codespell | 0m 26s | | No new issues. |
| +1 :green_heart: | compile | 0m 30s | | the patch passed |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | blanks | 0m 1s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 16s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 14s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 45s | | the patch passed |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 5m 11s | | tez-dag in the patch passed. |
| +1 :green_heart: | asflicense | 0m 14s | | The patch does not generate ASF License warnings. |
| | | 30m 9s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/433 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile |
| uname | Linux eda0a00b806e 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-433/src/.yetus/personality.sh |
| git revision | master / d5bfce2b9e7b712ce9b1fcf4cf40471aa57cf6f9 |
| Default Java | Ubuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/4/testReport/ |
| Max. process+thread count | 221 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/4/console |
| versions | git=2.43.0 maven=3.8.7 spotbugs=4.9.3 codespell=2.0.0 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TEZ-4650: Remove useless logic from AM plugin management: processSchedulerDescriptors [tez]
Posted by "tez-yetus (via GitHub)" <gi...@apache.org>.
tez-yetus commented on PR #433:
URL: https://github.com/apache/tez/pull/433#issuecomment-3352470743
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 26m 37s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ master Compile Tests _ |
| -1 :x: | mvninstall | 15m 15s | [/branch-mvninstall-root.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/3/artifact/out/branch-mvninstall-root.txt) | root in master failed. |
| +1 :green_heart: | compile | 0m 44s | | master passed |
| -0 :warning: | checkstyle | 0m 29s | [/buildtool-branch-checkstyle-tez-dag.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/3/artifact/out/buildtool-branch-checkstyle-tez-dag.txt) | The patch fails to run checkstyle in tez-dag |
| -1 :x: | javadoc | 0m 24s | [/branch-javadoc-tez-dag.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/3/artifact/out/branch-javadoc-tez-dag.txt) | tez-dag in master failed. |
| -1 :x: | spotbugs | 0m 25s | [/branch-spotbugs-tez-dag.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/3/artifact/out/branch-spotbugs-tez-dag.txt) | tez-dag in master failed. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 31s | | the patch passed |
| +1 :green_heart: | codespell | 0m 27s | | No new issues. |
| +1 :green_heart: | compile | 0m 31s | | the patch passed |
| +1 :green_heart: | javac | 0m 31s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| -0 :warning: | checkstyle | 1m 2s | [/results-checkstyle-tez-dag.txt](https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/3/artifact/out/results-checkstyle-tez-dag.txt) | tez-dag: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) |
| +1 :green_heart: | javadoc | 0m 24s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 44s | | the patch passed |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 5m 12s | | tez-dag in the patch passed. |
| +1 :green_heart: | asflicense | 0m 15s | | The patch does not generate ASF License warnings. |
| | | 56m 6s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/433 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs checkstyle codespell detsecrets compile |
| uname | Linux a16d59dfa204 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-home/workspace/tez-multibranch_PR-433/src/.yetus/personality.sh |
| git revision | master / 532f0f158cf92d3410ecdd93c21bc8b4dd7f0248 |
| Default Java | Ubuntu-21.0.8+9-Ubuntu-0ubuntu124.04.1 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/3/testReport/ |
| Max. process+thread count | 256 (vs. ulimit of 5500) |
| modules | C: tez-dag U: tez-dag |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-433/3/console |
| versions | git=2.43.0 maven=3.8.7 codespell=2.0.0 |
| Powered by | Apache Yetus 0.15.1 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org