You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "mengw15 (via GitHub)" <gi...@apache.org> on 2026/07/22 03:37:17 UTC
[I] add unit test coverage for FiltersComponent filter-building and selection logic [texera]
mengw15 opened a new issue, #6751:
URL: https://github.com/apache/texera/issues/6751
### Task Summary
`FiltersComponent` sits at codecov ~70% (59 uncovered lines) — its filter-list building and selection-update logic is largely untested. Extend the spec. jsdom/Vitest; see `frontend/TESTING.md`.
### Behavior to add
**FiltersComponent** (`frontend/src/app/dashboard/component/user/filters/filters.component.ts`, codecov ~70% — EXTEND)
- Search-parameter assembly: `getSearchKeywords` / `getSearchFilterParameters` / `searchParameterBackendSetup` — assert the parameters built from the selected owners/projects/operators/ids and ctime/mtime ranges.
- Master-filter list: `buildMasterFilterList` / `setMasterFilterList` / `updateMasterFilterList` / `removeInvalidFilterTag` — assert the tag list built and that an invalid tag is dropped.
- Selection updates: `updateSelectedOwners` / `updateSelectedProjects` / `updateSelectedOperators` / `updateSelectedIDs` / `updateDropdownMenus` / `setDropdownSelectionsToUnchecked` — assert the selection state and dropdown menu after each.
- `checkIfWorkflowName` — the predicate for a workflow-name filter tag.
Note on `getFormattedDateString`: assert it through `getSearchFilterParameters` with a fixed epoch, and do NOT hard-code a timezone-dependent rendered day (a `DatePipe`/locale string renders a different day under a UTC CI runner) — assert the format/structure or a TZ-stable substring.
### Task Type
- [ ] Refactor / Cleanup
- [ ] DevOps / Deployment / CI
- [x] Testing / QA
- [ ] Documentation
- [ ] Performance
- [ ] Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] add unit test coverage for FiltersComponent filter-building and selection logic [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #6751: add unit test coverage for FiltersComponent filter-building and selection logic
URL: https://github.com/apache/texera/issues/6751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] add unit test coverage for FiltersComponent filter-building and selection logic [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6751:
URL: https://github.com/apache/texera/issues/6751#issuecomment-5041564989
<!-- texera:template-compliance -->
👋 Thanks for opening this issue, @mengw15!
It looks like the issue description doesn't quite follow our template yet:
- This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org