[jira] [Resolved] (SOLR-5159) Manifest includes non-parsed maven variables

["Steve Rowe (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-5159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Rowe resolved SOLR-5159.
------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0
                   4.5

bq. I want to verify Maven2 locally, and I also want to compare all manifest entries with the Ant-produced ones - the solr entries were changed recently, and I want to keep them in sync.

Maven 2.2.1 works fine.

I compared the Ant-built and Maven-built manifests, and the Maven-built ones of course have lots of Bnd-produced entries not in the Ant-built ones.  There are two other differences:

# The Maven-built manifest contains Implementation-Vendor-Id (with Maven coordinate groupId as the value: org.apache.lucene or org.apache.solr).  I think this is fine to leave in, and maybe the Ant-built manifests should get it too?
# The Maven-built manifests have the old style {{Specification-Version}}, including a timestamp, e.g. {{5.0.0.2013.08.16.12.36.14}}, where the Ant-built manifests just have the version, e.g. {{5.0-SNAPSHOT}}.  The latter is actually syntactically incorrect, since the value should only have digits and period.  I've left it as the old style in the Maven version, since it's not a syntax error, and since the Maven versions will only ever be produced by end-users - all snapshot and release Maven artifacts are produced by Ant.

I've committed to trunk and branch_4x.

Thanks Artem!
                
> Manifest includes non-parsed maven variables
> --------------------------------------------
>
>                 Key: SOLR-5159
>                 URL: https://issues.apache.org/jira/browse/SOLR-5159
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 4.4, 4.5, 5.0
>         Environment: Apache Maven 3.0.5
>            Reporter: Artem Karpenko
>            Assignee: Steve Rowe
>            Priority: Minor
>              Labels: maven-bundle-plugin, maven3,
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-5159.patch
>
>
> When building Lucene/Solr with Apache Maven 3, all MANIFEST.MF files included into JAR artifacts contain non-parsed POM variables: namely, there are entries like
> Specification-Version: 5.0.0.$\{now.version}
> In the end, Solr displays these values on admin page in "Versions" section.
> This is caused by unresolved bug in maven-bundle-plugin (FELIX-3392). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org