You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "lujiajing1126 (via GitHub)" <gi...@apache.org> on 2023/04/14 01:38:24 UTC

[GitHub] [skywalking-java] lujiajing1126 opened a new pull request, #504: Exclude synthetic methods for WitnessMethod

lujiajing1126 opened a new pull request, #504:
URL: https://github.com/apache/skywalking-java/pull/504

   ### Fix https://github.com/apache/skywalking/issues/10679
   - [x] Add a unit test to verify that the fix works.
   - [x] Explain briefly why the bug exists and how to fix it.
   - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes https://github.com/apache/skywalking/issues/10679.
   - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] wu-sheng commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1508050738

   Other cases are passed. This is pretty strange.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] wu-sheng merged pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #504:
URL: https://github.com/apache/skywalking-java/pull/504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] wu-sheng commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1507970001

   @kezhenxu94 Any possible of cache issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] lujiajing1126 commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1507953493

   > The error is from Shenyi sofarpc case.
   
   From CI logs,
   
   ![image](https://user-images.githubusercontent.com/2568208/231951897-ef2986ea-b894-4cad-9f26-46c6eb819b3f.png)
   
   Local build does not report any error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] wu-sheng commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1508125140

   > hi， io.grpc:grpc-core:jar:[1.28.0] can not find .
   > 
   > > Failed to execute goal on project shenyu-sofarpc-gateway: Could not resolve dependencies for project org.apache.skywalking:shenyu-sofarpc-gateway:jar:1.0.0: Failed to collect dependencies at com.alipay.sofa:sofa-rpc-all:jar:5.7.6 -> io.grpc:grpc-netty-shaded:jar:1.28.0 -> io.grpc:grpc-core:jar:[1.28.0]: No versions available for io.grpc:grpc-core:jar:[1.28.0] within specified range -> [Help 1]
   > 
   > > Failure to transfer io.grpc:grpc-core/maven-metadata.xml from https://mvnrepository.com/ was cached in the local repository, resolution will not be reattempted until the update interval of mvnrepository has elapsed or updates are forced. Original error: Could not transfer metadata io.grpc:grpc-core/maven-metadata.xml from/to mvnrepository (https://mvnrepository.com/): Authorization failed for https://mvnrepository.com/io/grpc/grpc-core/maven-metadata.xml 403 Forbidden
   
   https://mvnrepository.com/artifact/io.grpc/grpc-core/1.28.0 still lists this version, which is very confused.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] lujiajing1126 commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1507840044

   CI reported `grpc-core` 1.28.0 is not found @wu-sheng @kezhenxu94 any idea?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] wu-sheng commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1508028324

   I just excluded this case(`shenyu-2.4.x-sofarpc-scenario`), let's see.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] kezhenxu94 commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1508080270

   
   > Local build does not report any error
   
   @lujiajing1126 did you try removing the local jar of grpc-core 1.28.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] wu-sheng commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1508077719

   Friendly ping @yu199195 as PMC member of Shenyu in case of they know what happens.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] lujiajing1126 commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1507975719

   > I have deleted the cache and rerun the CI, let's see
   
   Seems not working


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] lujiajing1126 commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1508086270

   > > Local build does not report any error
   > 
   > @lujiajing1126 did you try removing the local jar of grpc-core 1.28.0?
   
   Yes. I've removed the whole io/grpc cache dir. But I have several maven mirrors. I am not sure which is used by GitHub CI?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] yu199195 commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1508104863

   hi， io.grpc:grpc-core:jar:[1.28.0] can not find .
   
   >  Failed to execute goal on project shenyu-sofarpc-gateway: Could not resolve dependencies for project org.apache.skywalking:shenyu-sofarpc-gateway:jar:1.0.0: Failed to collect dependencies at com.alipay.sofa:sofa-rpc-all:jar:5.7.6 -> io.grpc:grpc-netty-shaded:jar:1.28.0 -> io.grpc:grpc-core:jar:[1.28.0]: No versions available for io.grpc:grpc-core:jar:[1.28.0] within specified range -> [Help 1]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] kezhenxu94 commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1508107418

   > > > Local build does not report any error
   > > 
   > > 
   > > @lujiajing1126 did you try removing the local jar of grpc-core 1.28.0?
   > 
   > Yes. I've removed the whole io/grpc cache dir. But I have several maven mirrors. I am not sure which is used by GitHub CI?
   
   GitHub CI doesn't use any mirror.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] kezhenxu94 commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1507972712

   I have deleted the cache and rerun the CI, let's see


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-java] wu-sheng commented on pull request #504: Exclude synthetic methods for WitnessMethod

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #504:
URL: https://github.com/apache/skywalking-java/pull/504#issuecomment-1507942622

   The error is from Shenyi sofarpc case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org