[GitHub] [spark] huaxingao commented on issue #26035: [SPARK-29360][PYTHON][ML] PySpark FPGrowthModel supports getter/setter

[GitBox <gi...@apache.org>]

huaxingao commented on issue #26035: [SPARK-29360][PYTHON][ML] PySpark FPGrowthModel supports getter/setter
URL: https://github.com/apache/spark/pull/26035#issuecomment-538766693
 
 
   > Same usual question - this doesn't take away an API, but temporarily adds some setters?
   
   This PR doesn't take away any APIs. It adds some new getters/setters. In the case of this file, these getters/setters are final. I will need to make one more change in this file in the last parity PR to add ```setPredictionCol``` in ```FPGrowthModel```. Right now I don't need to add ```setPredictionCol``` explicitly, because we still have both ```set/getPredictionCol``` in ```HasPredictionCol``` (```setPredictionCol``` will be removed from ```HasPredictionCol``` in the final parity PR)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org