You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/23 21:14:02 UTC

[GitHub] [arrow] carols10cents opened a new pull request #8515: [Rust] [Parquet] Start porting path_internal from C++ to handle def_levels and rep_levels

carols10cents opened a new pull request #8515:
URL: https://github.com/apache/arrow/pull/8515


   Hey @nevi-me, I was looking into helping out with the `def_levels` and `rep_levels` handling in `get_levels` in arrow_writer.rs, and the logic is... quite complex! I honestly have no idea how you're planning to get it to be the same as the C++ code without a direct port of the C++ algorithm; the code looks completely different right now so I feel like I have no chance of helping to fix the Rust code by looking at the C++ code.
   
   I feel like you've mentioned that you're working on fixing the def/rep level stuff somewhere and that it was taking a while; what do you think of a more direct correspondence with the C++ code that I've started here? Are there reasons not to go this way? 
   
   I wanted to see if this kind of direction would be helpful in getting the rust-parquet-arrow-writer branch merged into master, or if this is too much or too little or the wrong direction. Please advise, thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] carols10cents commented on pull request #8515: [Rust] [Parquet] Start porting path_internal from C++ to handle def_levels and rep_levels

Posted by GitBox <gi...@apache.org>.
carols10cents commented on pull request #8515:
URL: https://github.com/apache/arrow/pull/8515#issuecomment-716571753


   Talked with nevi out-of-band, going to close this :) Sorry for the noise!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8515: [Rust] [Parquet] Start porting path_internal from C++ to handle def_levels and rep_levels

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8515:
URL: https://github.com/apache/arrow/pull/8515#issuecomment-715598067


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on JIRA?
   https://issues.apache.org/jira/browse/ARROW
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] carols10cents closed pull request #8515: [Rust] [Parquet] Start porting path_internal from C++ to handle def_levels and rep_levels

Posted by GitBox <gi...@apache.org>.
carols10cents closed pull request #8515:
URL: https://github.com/apache/arrow/pull/8515


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org