You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Michael Wallendahl <mw...@spikus.com> on 2005/02/01 01:23:46 UTC
[PATCH] commit-email.pl : move $tmp_dir into configuration section
Attached is a small patch to commit-email.pl. Just moved an existing
variable declaration into the configuration section of the script.
Let me know if there is anything else you need from me.
-Mike
Re: [PATCH] commit-email.pl : move $tmp_dir into configuration section
Posted by Michael W Thelen <mi...@pietdepsi.com>.
Michael Wallendahl wrote:
> Attached is a small patch to commit-email.pl. Just moved an existing
> variable declaration into the configuration section of the script.
Thank you for the patch, I've filed it as issue #2215:
http://subversion.tigris.org/issues/show_bug.cgi?id=2215
--
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes. -- Douglas Adams
Re: [PATCH] commit-email.pl : move $tmp_dir into configuration section
Posted by Michael Wallendahl <mw...@spikus.com>.
Max Bowsher wrote:
> Michael Wallendahl wrote:
>
>> * tools/hook-scripts/commit-email.pl.in: Moved declaration of $tmp_dir
>> into configuration section of script. Added comment with examples.
>
> Actually, I don't think this need to be configurable. I've changed it
> to use $TEMP if it exists and is a directory. That should make any
> configuration unnecessary. Svnlook doesn't even use the temporary
> directory established in commit-email.pl in 1.1.x and later, anyway.
>
Awesome. Thank you!
-Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] commit-email.pl : move $tmp_dir into configuration section
Posted by Max Bowsher <ma...@ukf.net>.
Michael Wallendahl wrote:
> Attached is a small patch to commit-email.pl. Just moved an existing
> variable declaration into the configuration section of the script.
>
> Let me know if there is anything else you need from me.
>
> -Mike
>
>
>* tools/hook-scripts/commit-email.pl.in: Moved declaration of $tmp_dir
> into configuration section of script. Added comment with examples.
Actually, I don't think this need to be configurable. I've changed it to use
$TEMP if it exists and is a directory. That should make any configuration
unnecessary. Svnlook doesn't even use the temporary directory established in
commit-email.pl in 1.1.x and later, anyway.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org