You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/09/17 18:11:05 UTC
[GitHub] kohlia commented on a change in pull request #339: Localizing
hardcoded messages
kohlia commented on a change in pull request #339: Localizing hardcoded messages
URL: https://github.com/apache/cordova-plugin-camera/pull/339#discussion_r218172054
##########
File path: plugin.xml
##########
@@ -100,6 +100,7 @@
<clobbers target="CameraPopoverHandle" />
</js-module>
+ <resource-file src="src/ios/Camera.strings" target="en.lproj/Camera.strings" />
Review comment:
It will copy the hardcoded message into a language file named Camera.strings and we can load the message from this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org