You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/16 07:48:46 UTC
[GitHub] [beam] echauchot opened a new pull request #11135: Add spark
structured streaming runner to GBK load tests
echauchot opened a new pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392848080
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
Review comment:
Not sure if this should be in separate file or together with other test cases in `job__LoadTests_GBK_Java.grooy`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot merged pull request #11135: Add spark structured
streaming runner to load tests
Posted by GitBox <gi...@apache.org>.
echauchot merged pull request #11135: Add spark structured streaming runner to load tests
URL: https://github.com/apache/beam/pull/11135
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
mwalenia commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392883872
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_Smoke.groovy
##########
@@ -79,7 +79,23 @@ def smokeTestConfigurations = { datasetName -> [
fanout : 10,
iterations : 1,
]
+ ],
Review comment:
Jenkins logs show that nobody uses the smoke tests, I don't think it's worth the hassle to add more of them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
mwalenia commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392895171
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
Review comment:
I think we can split the job definitions runner-wise into files, that way the files won't get too bloated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lgajowy commented on issue #11135: Add spark structured
streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
lgajowy commented on issue #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-601393438
Great to hear that @echauchot ! And even greater that you contribute to that framework too. Should you have any questions, do not hesitate to ask. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392850100
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
+ [
+ [
+ title : 'Load test: 2GB of 10B records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_1",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
Review comment:
should this be `false`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r395290438
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
+ [
+ [
+ title : 'Load test: 2GB of 10B records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_1",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
Review comment:
Let's put `true` then. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392852028
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_Smoke.groovy
##########
@@ -79,7 +79,23 @@ def smokeTestConfigurations = { datasetName -> [
fanout : 10,
iterations : 1,
]
+ ],
Review comment:
I'm not really sure if "smoke" tests are used by anyone tbh. If not, I wouldn't bother adding new scenarios here and propose to create an issue to remove smoke tests (unused code, unused jobs). If however they are used then pls ignore this comment :)
@mwalenia could you confirm what is the case here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lgajowy commented on issue #11135: Add spark structured
streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
lgajowy commented on issue #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-599407824
Adding @mwalenia and @kamilwu (not sure which one of you guys is available so doubling my chances ;) ). Please one of you, take a look as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392860650
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
+ [
+ [
+ title : 'Load test: 2GB of 10B records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_1",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
Review comment:
This was for testing at first but, sure I can put true
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392850806
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
+ [
+ [
+ title : 'Load test: 2GB of 10B records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_1",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_sparkstructuredstreaming_${mode}_GBK_1",
+ sourceOptions : """
+ {
+ "numRecords": 200000000,
+ "keySizeBytes": 1,
+ "valueSizeBytes": 9
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: 2GB of 100B records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_2",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_2",
+ sourceOptions : """
+ {
+ "numRecords": 20000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+
+ title : 'Load test: 2GB of 100kB records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_3",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_3",
+ sourceOptions : """
+ {
+ "numRecords": 20000,
+ "keySizeBytes": 10000,
+ "valueSizeBytes": 90000
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+
+ ],
+ [
+ title : 'Load test: fanout 4 times with 2GB 10-byte records total',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : 'load_tests_Java_SparkStructuredStreaming_${mode}_GBK_4',
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_4",
+ sourceOptions : """
+ {
+ "numRecords": 5000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 4,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: fanout 8 times with 2GB 10-byte records total',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_5",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_5",
+ sourceOptions : """
+ {
+ "numRecords": 2500000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 8,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: reiterate 4 times 10kB values',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_6",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_6",
+ sourceOptions : """
+ {
+ "numRecords": 20000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90,
+ "numHotKeys": 200,
+ "hotKeyFraction": 1
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 4,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: reiterate 4 times 2MB values',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_7",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_7",
+ sourceOptions : """
+ {
+ "numRecords": 20000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90,
+ "numHotKeys": 10,
+ "hotKeyFraction": 1
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 4,
+ streaming : isStreaming
+ ]
+ ]
+ ]
+}
+
+def batchLoadTestJob = { scope, triggeringContext ->
+ def datasetName = loadTestsBuilder.getBigQueryDataset('load_test', triggeringContext)
+ loadTestsBuilder.loadTests(scope, CommonTestProperties.SDK.JAVA, loadTestConfigurations('batch', false, datasetName), "GBK", "batch")
+}
+
+PhraseTriggeringPostCommitBuilder.postCommitJob(
Review comment:
This runs only when we type `Run load test...` in the comment. Should we add the Cron-trigged version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392861467
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_Smoke.groovy
##########
@@ -79,7 +79,23 @@ def smokeTestConfigurations = { datasetName -> [
fanout : 10,
iterations : 1,
]
+ ],
Review comment:
ok waiting for the confirmation that it is useless
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392865231
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
Review comment:
as the java test file contained only dataflow tests, I separated spark but sure I can merge. Waiting for the answer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r405378856
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
+ [
+ [
+ title : 'Load test: 2GB of 10B records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_1",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on issue #11135: Add spark structured
streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on issue #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-610854511
run seed job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on issue #11135: Add spark structured
streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on issue #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-601050524
@lgajowy @mwalenia thanks again for the great performance framework you made ! It is complementary to Nexmark. Indeed nexmark is more high level complete user pipelines but your framework allows to perf test a single transform which is very useful when we change the translation of a transform in a runner (which I'm doing). Congrats guys !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on issue #11135: Add spark structured
streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on issue #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-599415534
thanks Lukasz for the prompt review ! Indeed there will be some availability issues in the coming weeks. I'm, for myslef, working while the kids are watching cartoons as schools are closed :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on issue #11135: Add spark structured
streaming runner to load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on issue #11135: Add spark structured streaming runner to load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-614471818
@lgajowy thanks, I squashed the commits, can I self merge ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot edited a comment on issue #11135: Add spark
structured streaming runner to load tests
Posted by GitBox <gi...@apache.org>.
echauchot edited a comment on issue #11135: Add spark structured streaming runner to load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-611935152
rebased on master in case the flaky test was fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r405385423
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_Smoke.groovy
##########
@@ -79,7 +79,23 @@ def smokeTestConfigurations = { datasetName -> [
fanout : 10,
iterations : 1,
]
+ ],
Review comment:
ok, I reverted the cahnge that added the smoke tests. I did not touch to other runners smoke tests, just in case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392861222
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
+ [
+ [
+ title : 'Load test: 2GB of 10B records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_1",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_sparkstructuredstreaming_${mode}_GBK_1",
+ sourceOptions : """
+ {
+ "numRecords": 200000000,
+ "keySizeBytes": 1,
+ "valueSizeBytes": 9
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: 2GB of 100B records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_2",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_2",
+ sourceOptions : """
+ {
+ "numRecords": 20000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+
+ title : 'Load test: 2GB of 100kB records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_3",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_3",
+ sourceOptions : """
+ {
+ "numRecords": 20000,
+ "keySizeBytes": 10000,
+ "valueSizeBytes": 90000
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+
+ ],
+ [
+ title : 'Load test: fanout 4 times with 2GB 10-byte records total',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : 'load_tests_Java_SparkStructuredStreaming_${mode}_GBK_4',
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_4",
+ sourceOptions : """
+ {
+ "numRecords": 5000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 4,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: fanout 8 times with 2GB 10-byte records total',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_5",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_5",
+ sourceOptions : """
+ {
+ "numRecords": 2500000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 8,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: reiterate 4 times 10kB values',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_6",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_6",
+ sourceOptions : """
+ {
+ "numRecords": 20000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90,
+ "numHotKeys": 200,
+ "hotKeyFraction": 1
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 4,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: reiterate 4 times 2MB values',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_7",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_7",
+ sourceOptions : """
+ {
+ "numRecords": 20000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90,
+ "numHotKeys": 10,
+ "hotKeyFraction": 1
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 4,
+ streaming : isStreaming
+ ]
+ ]
+ ]
+}
+
+def batchLoadTestJob = { scope, triggeringContext ->
+ def datasetName = loadTestsBuilder.getBigQueryDataset('load_test', triggeringContext)
+ loadTestsBuilder.loadTests(scope, CommonTestProperties.SDK.JAVA, loadTestConfigurations('batch', false, datasetName), "GBK", "batch")
+}
+
+PhraseTriggeringPostCommitBuilder.postCommitJob(
Review comment:
same as above ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on issue #11135: Add spark structured
streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on issue #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-610854350
@lgajowy @mwalenia I pushed two commits to address your review comments PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on issue #11135: Add spark structured
streaming runner to load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on issue #11135: Add spark structured streaming runner to load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-610882229
run seed job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r395290076
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_Smoke.groovy
##########
@@ -79,7 +79,23 @@ def smokeTestConfigurations = { datasetName -> [
fanout : 10,
iterations : 1,
]
+ ],
Review comment:
So I suggest to remove this part @echauchot. :)
and the issue: https://issues.apache.org/jira/browse/BEAM-9559
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on issue #11135: Add spark structured
streaming runner to load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on issue #11135: Add spark structured streaming runner to load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-611950859
@lgajowy @mwalenia build passes PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r405378970
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
+ [
+ [
+ title : 'Load test: 2GB of 10B records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_1",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_sparkstructuredstreaming_${mode}_GBK_1",
+ sourceOptions : """
+ {
+ "numRecords": 200000000,
+ "keySizeBytes": 1,
+ "valueSizeBytes": 9
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: 2GB of 100B records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_2",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_2",
+ sourceOptions : """
+ {
+ "numRecords": 20000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+
+ title : 'Load test: 2GB of 100kB records',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_3",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_3",
+ sourceOptions : """
+ {
+ "numRecords": 20000,
+ "keySizeBytes": 10000,
+ "valueSizeBytes": 90000
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+
+ ],
+ [
+ title : 'Load test: fanout 4 times with 2GB 10-byte records total',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : 'load_tests_Java_SparkStructuredStreaming_${mode}_GBK_4',
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_4",
+ sourceOptions : """
+ {
+ "numRecords": 5000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 4,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: fanout 8 times with 2GB 10-byte records total',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_5",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_5",
+ sourceOptions : """
+ {
+ "numRecords": 2500000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 8,
+ iterations : 1,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: reiterate 4 times 10kB values',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_6",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_6",
+ sourceOptions : """
+ {
+ "numRecords": 20000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90,
+ "numHotKeys": 200,
+ "hotKeyFraction": 1
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 4,
+ streaming : isStreaming
+ ]
+ ],
+ [
+ title : 'Load test: reiterate 4 times 2MB values',
+ test : 'org.apache.beam.sdk.loadtests.GroupByKeyLoadTest',
+ runner : CommonTestProperties.Runner.SPARK_STRUCTURED_STREAMING,
+ pipelineOptions: [
+ project : 'apache-beam-testing',
+ appName : "load_tests_Java_SparkStructuredStreaming_${mode}_GBK_7",
+ tempLocation : 'gs://temp-storage-for-perf-tests/loadtests',
+ publishToBigQuery : false,
+ bigQueryDataset : datasetName,
+ bigQueryTable : "java_SparkStructuredStreaming_${mode}_GBK_7",
+ sourceOptions : """
+ {
+ "numRecords": 20000000,
+ "keySizeBytes": 10,
+ "valueSizeBytes": 90,
+ "numHotKeys": 10,
+ "hotKeyFraction": 1
+ }
+ """.trim().replaceAll("\\s", ""),
+ fanout : 1,
+ iterations : 4,
+ streaming : isStreaming
+ ]
+ ]
+ ]
+}
+
+def batchLoadTestJob = { scope, triggeringContext ->
+ def datasetName = loadTestsBuilder.getBigQueryDataset('load_test', triggeringContext)
+ loadTestsBuilder.loadTests(scope, CommonTestProperties.SDK.JAVA, loadTestConfigurations('batch', false, datasetName), "GBK", "batch")
+}
+
+PhraseTriggeringPostCommitBuilder.postCommitJob(
Review comment:
cron added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on issue #11135: Add spark structured
streaming runner to load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on issue #11135: Add spark structured streaming runner to load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-611392062
flaky build (https://jira.apache.org/jira/browse/BEAM-5197). re-launching build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r392848153
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
Review comment:
@mwalenia could you confirm?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lgajowy commented on issue #11135: Add spark structured
streaming runner to load tests
Posted by GitBox <gi...@apache.org>.
lgajowy commented on issue #11135: Add spark structured streaming runner to load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-614532962
Sure, do the honours :) Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] lgajowy commented on a change in pull request #11135: Add
spark structured streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
lgajowy commented on a change in pull request #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#discussion_r395290928
##########
File path: .test-infra/jenkins/job_LoadTests_GBK_Java_spark_structured_streaming.groovy
##########
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import CommonJobProperties as commonJobProperties
+import CommonTestProperties
+import LoadTestsBuilder as loadTestsBuilder
+import PhraseTriggeringPostCommitBuilder
+
+def loadTestConfigurations = { mode, isStreaming, datasetName ->
Review comment:
I'm fine with both options then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on issue #11135: Add spark structured
streaming runner to load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on issue #11135: Add spark structured streaming runner to load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-611392123
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on issue #11135: Add spark structured
streaming runner to load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on issue #11135: Add spark structured streaming runner to load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-611935152
rebased on master in case the flaky test was corrected
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] echauchot commented on issue #11135: Add spark structured
streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
echauchot commented on issue #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-610881964
I also added CoGBK, Combine and Pardo load tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] mwalenia commented on issue #11135: Add spark structured
streaming runner to GBK load tests
Posted by GitBox <gi...@apache.org>.
mwalenia commented on issue #11135: Add spark structured streaming runner to GBK load tests
URL: https://github.com/apache/beam/pull/11135#issuecomment-599510302
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services