[GitHub] [cassandra] ekaterinadimitrova2 commented on pull request #1940: [CASSANDRA-17950] Enable dtest-offheap in CircleCI

[GitBox <gi...@apache.org>]

ekaterinadimitrova2 commented on PR #1940:
URL: https://github.com/apache/cassandra/pull/1940#issuecomment-1289061003

   `OK, I'll fix this. Off-topic, but patch gymnastics like this are something I hope we can eliminate with pipeline parameters. I'll write up a proposal this week (as an orthogonal concern, not blocking this PR).`
   +1, looking forward to it
   `I edited config-2_1.yml to add the new test and then ran generate.sh -a per the README instructions. Did I miss a step?`
   
   It is correct in most cases, but when we add new job things can move and apply to wrong jobs; _I think_ this is probably what happened here. That is why we need to check the final result to be sure the patches are still applicable. They were created for a bit different content after all. It seems you need to create the patches again as the old ones are not applicable anymore. Let me know if you need help. 
   
   `That's the commit I'm PRing here, so did you mean a different commit?`
   Definitely. This is what I wanted to send - https://github.com/apache/cassandra/blob/cassandra-3.11/.circleci/config-2_1.yml#L264-L269. Sorry about that
   
   `I feel a lot closer now than I did last week :)`
   Yup, almost there


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org