[GitHub] [spark] maropu commented on a change in pull request #29559: [SPARK-32717][SQL] Add a AQEOptimizer for AdaptiveSparkPlanExec

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #29559:
URL: https://github.com/apache/spark/pull/29559#discussion_r478825138



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -522,6 +522,15 @@ object SQLConf {
       .checkValue(_ >= 0, "The non-empty partition ratio must be positive number.")
       .createWithDefault(0.2)
 
+  val ADAPTIVE_OPTIMIZER_EXCLUDED_RULES =
+   buildConf("spark.sql.adaptive.optimizer.excludedRules")

Review comment:
       Since the PR description says nothing about adding this, I think its better to add it or separating this from this PR. The other part looks okay.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org