You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Christos Kozyrakis <ko...@gmail.com> on 2015/02/25 01:08:49 UTC
Review Request 31390: Added discovery info documentation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/
-----------------------------------------------------------
Review request for mesos, Connor Doyle and Niklas Nielsen.
Bugs: MESOS-2396
https://issues.apache.org/jira/browse/MESOS-2396
Repository: mesos
Description
-------
Added discovery info documentation.
Diffs
-----
docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
Diff: https://reviews.apache.org/r/31390/diff/
Testing
-------
Thanks,
Christos Kozyrakis
Re: Review Request 31390: Added discovery info documentation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review73944
-----------------------------------------------------------
Bad patch!
Reviews applied: [31390]
Failed command: ./support/apply-review.sh -n -r 31390
Error:
2015-02-25 00:14:17 URL:https://reviews.apache.org/r/31390/diff/raw/ [6009/6009] -> "31390.patch" [1]
31390.patch:12: trailing whitespace.
When your framework registers an executor or launches a task, it can provide additional information for service discovery. This information is stored by the Mesos master along with other imporant information such as the slave currently running the task. A service discovery system can programmatically retrieve this information in order to set up DNS entries, configure proxies, or update any consistent store used for service discovery in a Mesos cluster that runs multiple frameworks and multiple tasks.
31390.patch:71: trailing whitespace.
Many service discovery systems provide additional features that manage the visibility of services (e.g., ACLs in proxy based systems, security extensions to DNS, VLAN or subnet selection). It is not the intended use of the visibility field to manage such features. When a service discovery system retrieves the task or executor information from the master, it can decide how to handle tasks without DiscoveryInfo. For instance, tasks may be made non discoverable to other frameworks (equivalent to `visibility=FRAMEWORK`) or discoverable to all frameworks (equivalent to `visibility=CLUSTER`).
31390.patch:73: trailing whitespace.
The `name` field is a string that that provides the service discovery system with the name under which the task is discoverable. The typical use of the name field will be to provide a valid hostname. If name is not provided, it is up to the service discovery system to create a name for the task based on the name field in `taskInfo` or other information.
31390.patch:75: trailing whitespace.
The `environment`, `location`, and `version` fields provide first class support for common attributes used to differentiate between similar services in large deployments. The `environment` may receive values such as `PROD/QA/DEV`, the `location field` may receive values like `EAST-US/WEST-US/EUROPE/AMEA`, and the `version` field may receive values like v2.0/v0.9. The exact use of these fields is up to the service discovery system.
31390.patch:77: trailing whitespace.
The `ports` field allows the framework to identify the ports a task listens to and explicitly name the functionality they represent and the layer-4 protocol they use (TCP, UDP, or other). For example, a Cassandra task will define ports like `“7000,Cluster,TCP”`, `“7001,SSL,TCP”`, `“9160,Thrift,TCP”`, `“9042,Native,TCP”`, and `“7199,JMX,TCP”`. It is up to the service discovery system to use these names and protocol in appropriate ways, potentially combining them with the name field in DiscoveryInfo.
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.
Successfully applied: Added discovery info documentation.
Added discovery info documentation.
Review: https://reviews.apache.org/r/31390
docs/app-framework-development-guide.md:215: trailing whitespace.
+When your framework registers an executor or launches a task, it can provide additional information for service discovery. This information is stored by the Mesos master along with other imporant information such as the slave currently running the task. A service discovery system can programmatically retrieve this information in order to set up DNS entries, configure proxies, or update any consistent store used for service discovery in a Mesos cluster that runs multiple frameworks and multiple tasks.
docs/app-framework-development-guide.md:274: trailing whitespace.
+Many service discovery systems provide additional features that manage the visibility of services (e.g., ACLs in proxy based systems, security extensions to DNS, VLAN or subnet selection). It is not the intended use of the visibility field to manage such features. When a service discovery system retrieves the task or executor information from the master, it can decide how to handle tasks without DiscoveryInfo. For instance, tasks may be made non discoverable to other frameworks (equivalent to `visibility=FRAMEWORK`) or discoverable to all frameworks (equivalent to `visibility=CLUSTER`).
docs/app-framework-development-guide.md:276: trailing whitespace.
+The `name` field is a string that that provides the service discovery system with the name under which the task is discoverable. The typical use of the name field will be to provide a valid hostname. If name is not provided, it is up to the service discovery system to create a name for the task based on the name field in `taskInfo` or other information.
docs/app-framework-development-guide.md:278: trailing whitespace.
+The `environment`, `location`, and `version` fields provide first class support for common attributes used to differentiate between similar services in large deployments. The `environment` may receive values such as `PROD/QA/DEV`, the `location field` may receive values like `EAST-US/WEST-US/EUROPE/AMEA`, and the `version` field may receive values like v2.0/v0.9. The exact use of these fields is up to the service discovery system.
docs/app-framework-development-guide.md:280: trailing whitespace.
+The `ports` field allows the framework to identify the ports a task listens to and explicitly name the functionality they represent and the layer-4 protocol they use (TCP, UDP, or other). For example, a Cassandra task will define ports like `“7000,Cluster,TCP”`, `“7001,SSL,TCP”`, `“9160,Thrift,TCP”`, `“9042,Native,TCP”`, and `“7199,JMX,TCP”`. It is up to the service discovery system to use these names and protocol in appropriate ways, potentially combining them with the name field in DiscoveryInfo.
docs/app-framework-development-guide.md:282: trailing whitespace.
+The `labels` field allows a framework to pass arbitrary labels to the service discovery system in the form of key/value pairs. Note that anything passed through this field is not guaranteed to be supported moving forward. Nevertheless, this field provides extensibility. Common uses of this field will allow us to identify use cases that require first class support.
docs/app-framework-development-guide.md:283: new blank line at EOF.
Failed to commit patch
- Mesos ReviewBot
On Feb. 25, 2015, 12:08 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 12:08 a.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review73952
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31390]
All tests passed.
- Mesos ReviewBot
On Feb. 25, 2015, 12:22 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 12:22 a.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review73982
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31390]
All tests passed.
- Mesos ReviewBot
On Feb. 25, 2015, 5:38 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 5:38 a.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Christos Kozyrakis <ko...@gmail.com>.
> On Feb. 25, 2015, 12:36 a.m., Adam B wrote:
> > docs/app-framework-development-guide.md, lines 220-235
> > <https://reviews.apache.org/r/31390/diff/3/?file=875231#file875231line220>
> >
> > Do you really need to bother showing the definition of Port[s] here? You don't copy the definition of Labels, and that's another DiscoveryInfo member type.
> > Anybody getting that deep into it can/will go directly to the protobuf definitions anyway.
I merely followed what seems to be the practice in the rest of this document. Someone should spend a few minutes documenting dos and donts for documentation. That will save all of us time in the future by getting "the right thing" there in the first place.
> On Feb. 25, 2015, 12:36 a.m., Adam B wrote:
> > docs/app-framework-development-guide.md, lines 238-250
> > <https://reviews.apache.org/r/31390/diff/3/?file=875231#file875231line238>
> >
> > Do you really need to include this lengthy comment if you're copying its contents below? Once is enough. Your choice which one.
I merely followed what seems to be the practice in the rest of this document. Someone should spend a few minutes documenting dos and donts for documentation. That will save all of us time in the future by getting "the right thing" there in the first place.
- Christos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review73997
-----------------------------------------------------------
On Feb. 24, 2015, 9:38 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 9:38 p.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Feb. 25, 2015, 12:36 a.m., Adam B wrote:
> > Looks great, although potentially more verbose than necessary.
+1 on both comments. Let's get those fixed and land this :) I'll update the changelog patch accordingly.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review73997
-----------------------------------------------------------
On Feb. 24, 2015, 9:38 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 9:38 p.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review73997
-----------------------------------------------------------
Ship it!
Looks great, although potentially more verbose than necessary.
docs/app-framework-development-guide.md
<https://reviews.apache.org/r/31390/#comment120436>
Do you really need to bother showing the definition of Port[s] here? You don't copy the definition of Labels, and that's another DiscoveryInfo member type.
Anybody getting that deep into it can/will go directly to the protobuf definitions anyway.
docs/app-framework-development-guide.md
<https://reviews.apache.org/r/31390/#comment120435>
Do you really need to include this lengthy comment if you're copying its contents below? Once is enough. Your choice which one.
- Adam B
On Feb. 24, 2015, 9:38 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 9:38 p.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review73989
-----------------------------------------------------------
Can you link to a rendered markdown version of this? Perhaps just a fork of Mesos under https://github.com/kozyraki
That'll make this much easier to read/review. Thanks.
- Adam B
On Feb. 24, 2015, 9:38 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 9:38 p.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Christos Kozyrakis <ko...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 11:16 a.m.)
Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
Changes
-------
Minor markdown fixes.
Bugs: MESOS-2396
https://issues.apache.org/jira/browse/MESOS-2396
Repository: mesos
Description
-------
Added discovery info documentation.
Diffs (updated)
-----
docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
Diff: https://reviews.apache.org/r/31390/diff/
Testing
-------
Thanks,
Christos Kozyrakis
Re: Review Request 31390: Added discovery info documentation.
Posted by Adam B <ad...@mesosphere.io>.
> On Feb. 25, 2015, 11:08 a.m., Adam B wrote:
> > Minor markdown tweaks, but I'll fix those myself and commit this.
Submitted.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review74051
-----------------------------------------------------------
On Feb. 25, 2015, 9:15 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 9:15 a.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Benjamin Mahler <be...@gmail.com>.
Sorry, that was in reply to Adam.
On Wed, Feb 25, 2015 at 2:33 PM, Christos Kozyrakis <ko...@gmail.com>
wrote:
> If by INFRA you meant JIRA:
> https://issues.apache.org/jira/browse/MESOS-2396
> Otherwise, I am not sure what an INFRA ticket is.
>
> On Wed, Feb 25, 2015 at 1:39 PM, Benjamin Mahler <
> benjamin.mahler@gmail.com> wrote:
>
>> Have you filed an INFRA ticket about that?
>>
>> On Wed, Feb 25, 2015 at 12:46 PM, Adam B <ad...@mesosphere.io> wrote:
>>
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/31390/
>>>
>>> On February 25th, 2015, 11:08 a.m. PST, *Adam B* wrote:
>>>
>>> Minor markdown tweaks, but I'll fix those myself and commit this.
>>>
>>> On February 25th, 2015, 11:14 a.m. PST, *Adam B* wrote:
>>>
>>> Submitted.
>>>
>>> On February 25th, 2015, 11:53 a.m. PST, *Ben Mahler* wrote:
>>>
>>> Adam: Did you forget to mark this review as submitted?
>>>
>>> Unfortunately, I don't have permission to mark others reviews as submitted (I did before one of the RB upgrades). @kozyraki can you mark it as submitted?
>>>
>>>
>>> - Adam
>>>
>>> On February 25th, 2015, 11:16 a.m. PST, Christos Kozyrakis wrote:
>>> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
>>> By Christos Kozyrakis.
>>>
>>> *Updated Feb. 25, 2015, 11:16 a.m.*
>>> *Bugs: * MESOS-2396 <https://issues.apache.org/jira/browse/MESOS-2396>
>>> *Repository: * mesos
>>> Description
>>>
>>> Added discovery info documentation.
>>>
>>> Diffs
>>>
>>> - docs/app-framework-development-guide.md
>>> (dd7603d099f7582fa8fe93a4c3daa521b23f6223)
>>>
>>> View Diff <https://reviews.apache.org/r/31390/diff/>
>>>
>>
>>
>
>
> --
> Christos
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Benjamin Mahler <be...@gmail.com>.
Have you filed an INFRA ticket about that?
On Wed, Feb 25, 2015 at 12:46 PM, Adam B <ad...@mesosphere.io> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
>
> On February 25th, 2015, 11:08 a.m. PST, *Adam B* wrote:
>
> Minor markdown tweaks, but I'll fix those myself and commit this.
>
> On February 25th, 2015, 11:14 a.m. PST, *Adam B* wrote:
>
> Submitted.
>
> On February 25th, 2015, 11:53 a.m. PST, *Ben Mahler* wrote:
>
> Adam: Did you forget to mark this review as submitted?
>
> Unfortunately, I don't have permission to mark others reviews as submitted (I did before one of the RB upgrades). @kozyraki can you mark it as submitted?
>
>
> - Adam
>
> On February 25th, 2015, 11:16 a.m. PST, Christos Kozyrakis wrote:
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
> By Christos Kozyrakis.
>
> *Updated Feb. 25, 2015, 11:16 a.m.*
> *Bugs: * MESOS-2396 <https://issues.apache.org/jira/browse/MESOS-2396>
> *Repository: * mesos
> Description
>
> Added discovery info documentation.
>
> Diffs
>
> - docs/app-framework-development-guide.md
> (dd7603d099f7582fa8fe93a4c3daa521b23f6223)
>
> View Diff <https://reviews.apache.org/r/31390/diff/>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Adam B <ad...@mesosphere.io>.
> On Feb. 25, 2015, 11:08 a.m., Adam B wrote:
> > Minor markdown tweaks, but I'll fix those myself and commit this.
>
> Adam B wrote:
> Submitted.
>
> Ben Mahler wrote:
> Adam: Did you forget to mark this review as submitted?
Unfortunately, I don't have permission to mark others reviews as submitted (I did before one of the RB upgrades). @kozyraki can you mark it as submitted?
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review74051
-----------------------------------------------------------
On Feb. 25, 2015, 11:16 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 11:16 a.m.)
>
>
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Ben Mahler <be...@gmail.com>.
> On Feb. 25, 2015, 7:08 p.m., Adam B wrote:
> > Minor markdown tweaks, but I'll fix those myself and commit this.
>
> Adam B wrote:
> Submitted.
Adam: Did you forget to mark this review as submitted?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review74051
-----------------------------------------------------------
On Feb. 25, 2015, 7:16 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 7:16 p.m.)
>
>
> Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review74051
-----------------------------------------------------------
Ship it!
Minor markdown tweaks, but I'll fix those myself and commit this.
docs/app-framework-development-guide.md
<https://reviews.apache.org/r/31390/#comment120554>
s/`location field`/`location` field/
docs/app-framework-development-guide.md
<https://reviews.apache.org/r/31390/#comment120564>
s/name field/`name` field/
- Adam B
On Feb. 25, 2015, 9:15 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 9:15 a.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Christos Kozyrakis <ko...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/
-----------------------------------------------------------
(Updated Feb. 25, 2015, 9:15 a.m.)
Review request for mesos, Connor Doyle and Niklas Nielsen.
Changes
-------
Reduced verbosity.
Bugs: MESOS-2396
https://issues.apache.org/jira/browse/MESOS-2396
Repository: mesos
Description
-------
Added discovery info documentation.
Diffs (updated)
-----
docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
Diff: https://reviews.apache.org/r/31390/diff/
Testing
-------
Thanks,
Christos Kozyrakis
Re: Review Request 31390: Added discovery info documentation.
Posted by Christos Kozyrakis <ko...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 9:38 p.m.)
Review request for mesos, Connor Doyle and Niklas Nielsen.
Changes
-------
Clarified visibility field.
Bugs: MESOS-2396
https://issues.apache.org/jira/browse/MESOS-2396
Repository: mesos
Description
-------
Added discovery info documentation.
Diffs (updated)
-----
docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
Diff: https://reviews.apache.org/r/31390/diff/
Testing
-------
Thanks,
Christos Kozyrakis
Re: Review Request 31390: Added discovery info documentation.
Posted by Christos Kozyrakis <ko...@gmail.com>.
> On Feb. 24, 2015, 7:18 p.m., Connor Doyle wrote:
> > docs/app-framework-development-guide.md, line 270
> > <https://reviews.apache.org/r/31390/diff/2/?file=874617#file874617line270>
> >
> > Would you like to expand on the meaning of discoverability here? For example, does this mean that other tasks started by the same scheduler should be able to discover this task?
> >
> > Similarly, since Mesos doesn't enforce any of the discoverability, should `is not` instead read `should not be`?
It will be very difficult to address this issue convincingly because it depends on the service discovery system, the networking setup, and whether Mesos allows you to inspect all running tasks through some endpoints etc. All we are doing here is providing info. What the service discovery system does with this info is largely undefined and out of scope. So for now I will change "is not" to "should not be".
- Christos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review73969
-----------------------------------------------------------
On Feb. 24, 2015, 4:22 p.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 4:22 p.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Connor Doyle <co...@mesosphere.io>.
> On Feb. 25, 2015, 3:18 a.m., Connor Doyle wrote:
> > docs/app-framework-development-guide.md, line 270
> > <https://reviews.apache.org/r/31390/diff/2/?file=874617#file874617line270>
> >
> > Would you like to expand on the meaning of discoverability here? For example, does this mean that other tasks started by the same scheduler should be able to discover this task?
> >
> > Similarly, since Mesos doesn't enforce any of the discoverability, should `is not` instead read `should not be`?
>
> Christos Kozyrakis wrote:
> It will be very difficult to address this issue convincingly because it depends on the service discovery system, the networking setup, and whether Mesos allows you to inspect all running tasks through some endpoints etc. All we are doing here is providing info. What the service discovery system does with this info is largely undefined and out of scope. So for now I will change "is not" to "should not be".
SGTM, thanks.
- Connor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review73969
-----------------------------------------------------------
On Feb. 25, 2015, 5:38 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 5:38 a.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Connor Doyle <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/#review73969
-----------------------------------------------------------
docs/app-framework-development-guide.md
<https://reviews.apache.org/r/31390/#comment120376>
Would you like to expand on the meaning of discoverability here? For example, does this mean that other tasks started by the same scheduler should be able to discover this task?
Similarly, since Mesos doesn't enforce any of the discoverability, should `is not` instead read `should not be`?
- Connor Doyle
On Feb. 25, 2015, 12:22 a.m., Christos Kozyrakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31390/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2015, 12:22 a.m.)
>
>
> Review request for mesos, Connor Doyle and Niklas Nielsen.
>
>
> Bugs: MESOS-2396
> https://issues.apache.org/jira/browse/MESOS-2396
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added discovery info documentation.
>
>
> Diffs
> -----
>
> docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
>
> Diff: https://reviews.apache.org/r/31390/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christos Kozyrakis
>
>
Re: Review Request 31390: Added discovery info documentation.
Posted by Christos Kozyrakis <ko...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31390/
-----------------------------------------------------------
(Updated Feb. 24, 2015, 4:22 p.m.)
Review request for mesos, Connor Doyle and Niklas Nielsen.
Changes
-------
Fixed trailing whitespaces.
Bugs: MESOS-2396
https://issues.apache.org/jira/browse/MESOS-2396
Repository: mesos
Description
-------
Added discovery info documentation.
Diffs (updated)
-----
docs/app-framework-development-guide.md dd7603d099f7582fa8fe93a4c3daa521b23f6223
Diff: https://reviews.apache.org/r/31390/diff/
Testing
-------
Thanks,
Christos Kozyrakis