[GitHub] [lucene-solr] andyvuong commented on a change in pull request #1369: SOLR-14213: Allow enabling shared store to be scriptable

[GitBox <gi...@apache.org>]

andyvuong commented on a change in pull request #1369: SOLR-14213: Allow enabling shared store to be scriptable
URL: https://github.com/apache/lucene-solr/pull/1369#discussion_r396649036
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java
 ##########
 @@ -568,4 +568,17 @@ private static PluginInfo getTracerPluginInfo(XmlConfigFile config) {
     Node node = config.getNode("solr/tracerConfig", false);
     return (node == null) ? null : new PluginInfo(node, "tracerConfig", false, true);
   }
+  
+  private static SharedStoreConfig loadSharedStoreConfig(NamedList<Object> nl) {
 
 Review comment:
   fyi I moved the actual initialization method from SharedStoreConfig to SolrXmlConfig to avoid duplicating the existing field extraction methods or changing their visibility and so it aligns with how the rest of the section objects are being created. I've kept the SharedStoreConfig since I anticipate we'll start using it once we complete the enabling configurable's work. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org