You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/06 22:47:01 UTC

[GitHub] [incubator-nuttx] acassis opened a new pull request #1526: Add Ethernet netnsh board configuration example

acassis opened a new pull request #1526:
URL: https://github.com/apache/incubator-nuttx/pull/1526


   ## Summary
   Add Ethernet netnsh board configuration example
   ## Impact
   Make it easy to users to test the Ethernet
   ## Testing
   ESP32-Ethernet-Kit_A_V1.1
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1526: Add Ethernet netnsh board configuration example

Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #1526:
URL: https://github.com/apache/incubator-nuttx/pull/1526#issuecomment-670230782


   Please don't merge your own PRs into master!  We don't do that on this project.  We ask others to review and merge our PRs.  If you merge your own PR you are not being responsible toward the code base.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #1526: Add Ethernet netnsh board configuration example

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1526:
URL: https://github.com/apache/incubator-nuttx/pull/1526#issuecomment-670479805


   Sorry, I didn't see I merge it. It should had happened when I clicked to PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1526: Add Ethernet netnsh board configuration example

Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #1526:
URL: https://github.com/apache/incubator-nuttx/pull/1526#issuecomment-670230782


   Please don't merge your own PRs into master!  We don't do that on this project.  We ask others to review and merge our PRs.  If you merge your own PR you are not being responsible toward the code base.
   
   Hmmm.. you did not even let the PR checks pass.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #1526: Add Ethernet netnsh board configuration example

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1526:
URL: https://github.com/apache/incubator-nuttx/pull/1526#issuecomment-670487016


   > Please don't merge your own PRs into master! We don't do that on this project. We ask others to review and merge our PRs. If you merge your own PR you are not being responsible toward the code base.
   > 
   > Hmmm.. you did not even let the PR checks pass.
   
   I think a way to avoid it to happen is blocking the "Merge" button before the CI finish its test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1526: Add Ethernet netnsh board configuration example

Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #1526:
URL: https://github.com/apache/incubator-nuttx/pull/1526#issuecomment-670230782


   Please don't merge your own PRs into master!  We don't do that on this project.  We ask others to review and merge our PRs.  If you merge your own PR you are not being responsible oward the code base.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #1526: Add Ethernet netnsh board configuration example

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1526:
URL: https://github.com/apache/incubator-nuttx/pull/1526#issuecomment-670479921


   > When new configurations are added, they must be documented in boards/xtemsa/esp32/esp32-core/README.txt. Don't forget your documentation responsibilities.
   
   Ok, I will do that!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1526: Add Ethernet netnsh board configuration example

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1526:
URL: https://github.com/apache/incubator-nuttx/pull/1526#issuecomment-670230782


   Please don't merge your own PRs into master!  We don't do that on this project.  We ask others to review and merge our PRs.  If you merge your own PR you are no being responsible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1526: Add Ethernet netnsh board configuration example

Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #1526:
URL: https://github.com/apache/incubator-nuttx/pull/1526#issuecomment-670230782


   Please don't merge your own PRs into master!  We don't do that on this project.  We ask others to review and merge our PRs.  If you merge your own PR you are not being responsible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #1526: Add Ethernet netnsh board configuration example

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1526:
URL: https://github.com/apache/incubator-nuttx/pull/1526


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org