You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/08 09:16:56 UTC
[GitHub] [hbase-operator-tools] ZhaoBQ opened a new pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
ZhaoBQ opened a new pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75
[HBASE-24997](https://issues.apache.org/jira/browse/HBASE-24997)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil merged pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
wchevreuil merged pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75#issuecomment-688753805
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 1s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 1s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 59s | master passed |
| +1 :green_heart: | compile | 0m 13s | master passed |
| +1 :green_heart: | checkstyle | 0m 9s | master passed |
| +1 :green_heart: | javadoc | 0m 9s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 15s | the patch passed |
| +1 :green_heart: | compile | 0m 13s | the patch passed |
| +1 :green_heart: | javac | 0m 13s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 7s | hbase-tools: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 8s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 25m 27s | hbase-tools in the patch failed. |
| +1 :green_heart: | asflicense | 0m 8s | The patch does not generate ASF License warnings. |
| | | 29m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-75/1/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/75 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux dd5943c1fe29 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 87878aa |
| Default Java | Oracle Corporation-1.8.0_265-b01 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-75/1/artifact/yetus-precommit-check/output/patch-unit-hbase-tools.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-75/1/testReport/ |
| Max. process+thread count | 747 (vs. ulimit of 1000) |
| modules | C: hbase-tools U: hbase-tools |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-75/1/console |
| versions | git=2.20.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil merged pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
wchevreuil merged pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil merged pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
wchevreuil merged pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on a change in pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75#discussion_r485686626
##########
File path: hbase-tools/src/test/java/org/apache/hbase/TestRegionsMerger.java
##########
@@ -132,6 +138,27 @@ public void testMergeRegionsInvalidParams() throws Exception {
originalCount, TEST_UTIL.countRows(table));
}
+ @Test
+ public void testRegionHasNoState() throws Exception {
+ // Turn on the replication of the table, and then merge two regions, the parent regions will
+ // not have the column info:state in the meta table, only the column
+ // rep_barrier:seqnumDuringOpen is left. And we should skip the parent regions.
+ TableDescriptor tableDesc = TEST_UTIL.getAdmin().getDescriptor(TABLE_NAME);
+ TEST_UTIL.getAdmin().modifyTable(TableDescriptorBuilder.newBuilder(tableDesc).
Review comment:
This looks like a bug on the merge or unassign procedure. Can you change this test to manually produce a region with no state defined, instead of relying on additional features that seem to not work properly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] ZhaoBQ commented on pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
ZhaoBQ commented on pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75#issuecomment-690841484
In my local environment, the tests have passed. Can you take a look @wchevreuil ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
wchevreuil commented on a change in pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75#discussion_r484808209
##########
File path: hbase-tools/src/test/java/org/apache/hbase/TestRegionsMerger.java
##########
@@ -132,6 +138,27 @@ public void testMergeRegionsInvalidParams() throws Exception {
originalCount, TEST_UTIL.countRows(table));
}
+ @Test
+ public void testRegionHasNoState() throws Exception {
+ // Turn on the replication of the table, and then merge two regions, the parent regions will
+ // not have the column info:state in the meta table, only the column
+ // rep_barrier:seqnumDuringOpen is left. And we should skip the parent regions.
+ TableDescriptor tableDesc = TEST_UTIL.getAdmin().getDescriptor(TABLE_NAME);
+ TEST_UTIL.getAdmin().modifyTable(TableDescriptorBuilder.newBuilder(tableDesc).
Review comment:
Why setting replication scope in this test? Do we need to set replication scope in order to reproduce the "no state info" condition?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] ZhaoBQ commented on a change in pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
ZhaoBQ commented on a change in pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75#discussion_r485298853
##########
File path: hbase-tools/src/test/java/org/apache/hbase/TestRegionsMerger.java
##########
@@ -132,6 +138,27 @@ public void testMergeRegionsInvalidParams() throws Exception {
originalCount, TEST_UTIL.countRows(table));
}
+ @Test
+ public void testRegionHasNoState() throws Exception {
+ // Turn on the replication of the table, and then merge two regions, the parent regions will
+ // not have the column info:state in the meta table, only the column
+ // rep_barrier:seqnumDuringOpen is left. And we should skip the parent regions.
+ TableDescriptor tableDesc = TEST_UTIL.getAdmin().getDescriptor(TABLE_NAME);
+ TEST_UTIL.getAdmin().modifyTable(TableDescriptorBuilder.newBuilder(tableDesc).
Review comment:
Yes, I only found that after setting replication scope, there will be regions without info:state in meta.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] ZhaoBQ commented on pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
ZhaoBQ commented on pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75#issuecomment-690841484
In my local environment, the tests have passed. Can you take a look @wchevreuil ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] ZhaoBQ commented on a change in pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
ZhaoBQ commented on a change in pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75#discussion_r486291661
##########
File path: hbase-tools/src/test/java/org/apache/hbase/TestRegionsMerger.java
##########
@@ -132,6 +138,27 @@ public void testMergeRegionsInvalidParams() throws Exception {
originalCount, TEST_UTIL.countRows(table));
}
+ @Test
+ public void testRegionHasNoState() throws Exception {
+ // Turn on the replication of the table, and then merge two regions, the parent regions will
+ // not have the column info:state in the meta table, only the column
+ // rep_barrier:seqnumDuringOpen is left. And we should skip the parent regions.
+ TableDescriptor tableDesc = TEST_UTIL.getAdmin().getDescriptor(TABLE_NAME);
+ TEST_UTIL.getAdmin().modifyTable(TableDescriptorBuilder.newBuilder(tableDesc).
Review comment:
OK, did as you said. Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75#issuecomment-690252349
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 58s | master passed |
| +1 :green_heart: | compile | 0m 12s | master passed |
| +1 :green_heart: | checkstyle | 0m 9s | master passed |
| +1 :green_heart: | javadoc | 0m 9s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 13s | the patch passed |
| +1 :green_heart: | compile | 0m 12s | the patch passed |
| +1 :green_heart: | javac | 0m 12s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 6s | hbase-tools: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 7s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 13m 8s | hbase-tools in the patch failed. |
| +1 :green_heart: | asflicense | 0m 7s | The patch does not generate ASF License warnings. |
| | | 16m 2s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hbase.TestRegionsMerger |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-75/2/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/75 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux b30d952e9e82 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 87878aa |
| Default Java | Oracle Corporation-1.8.0_265-b01 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-75/2/artifact/yetus-precommit-check/output/patch-unit-hbase-tools.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-75/2/testReport/ |
| Max. process+thread count | 915 (vs. ulimit of 1000) |
| modules | C: hbase-tools U: hbase-tools |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-75/2/console |
| versions | git=2.20.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] ZhaoBQ commented on pull request #75: HBASE-24997 [hbase-operator-tools] NPE in RegionsMerger#mergeRegions
Posted by GitBox <gi...@apache.org>.
ZhaoBQ commented on pull request #75:
URL: https://github.com/apache/hbase-operator-tools/pull/75#issuecomment-690841484
In my local environment, the tests have passed. Can you take a look @wchevreuil ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org