You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Arvind Prabhakar <ar...@apache.org> on 2012/04/01 20:23:13 UTC
Re: Review Request: FLUME-1073: Default shipping log4j config to rolling
file appender
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4565/#review6612
-----------------------------------------------------------
Ship it!
+1.
Thanks for the patch Mike. Please attach the patch to the Jira.
- Arvind
On 2012-03-30 21:38:31, Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4565/
> -----------------------------------------------------------
>
> (Updated 2012-03-30 21:38:31)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Simple patch to default to a reasonably-configured rolling file appender.
>
>
> This addresses bug FLUME-1073.
> https://issues.apache.org/jira/browse/FLUME-1073
>
>
> Diffs
> -----
>
> bin/flume-ng a31f171
> conf/log4j.properties 3dcffd4
>
> Diff: https://reviews.apache.org/r/4565/diff
>
>
> Testing
> -------
>
> Did some manual testing, looks fine to me.
>
>
> Thanks,
>
> Mike
>
>