You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@etch.apache.org by ve...@apache.org on 2012/08/02 18:17:22 UTC
svn commit: r1368575 - in
/incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu:
include/capu/os/ include/capu/os/arch/Linux/ include/capu/os/arch/Windows/
test/os/ test/os/arch/X86_32/
Author: veithm
Date: Thu Aug 2 16:17:22 2012
New Revision: 1368575
URL: http://svn.apache.org/viewvc?rev=1368575&view=rev
Log:
ETCH-207 Removed some warnings in Linux build
Change-Id: If9fdb4010d214fb7202e062ad4001e20fa8adc7d
Modified:
incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/File.h
incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/arch/Linux/File.inc
incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/arch/Windows/File.inc
incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/AtomicOperationTest.cpp
incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/FileTest.cpp
incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/arch/X86_32/AtomicOperation.inc
Modified: incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/File.h
URL: http://svn.apache.org/viewvc/incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/File.h?rev=1368575&r1=1368574&r2=1368575&view=diff
==============================================================================
--- incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/File.h (original)
+++ incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/File.h Thu Aug 2 16:17:22 2012
@@ -66,7 +66,7 @@ namespace capu {
CAPU_EOF if end of stream
CAPU_ERROR if invalid state or file not open
*/
- inline status_t read(char * buffer, int32_t length, int32_t* numBytes);
+ inline status_t read(char * buffer, uint32_t length, int32_t* numBytes);
/**
* Writes the given byte buffer to the stream.
@@ -75,7 +75,7 @@ namespace capu {
* return CAPU_OK buffer could be written to the stream
* CAPU_ERROR otherwise
*/
- inline status_t write(char * buffer, int32_t length);
+ inline status_t write(char * buffer, uint32_t length);
/**
* Writes any unwritten data to the file.
Modified: incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/arch/Linux/File.inc
URL: http://svn.apache.org/viewvc/incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/arch/Linux/File.inc?rev=1368575&r1=1368574&r2=1368575&view=diff
==============================================================================
--- incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/arch/Linux/File.inc (original)
+++ incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/arch/Linux/File.inc Thu Aug 2 16:17:22 2012
@@ -49,7 +49,7 @@
return (feof(mHandle) != 0);
}
- inline status_t File::read(char * buffer, int32_t length, int32_t* numBytes) {
+ inline status_t File::read(char * buffer, uint32_t length, int32_t* numBytes) {
if(buffer == NULL) {
return CAPU_EINVAL;
}
@@ -74,7 +74,7 @@
return CAPU_ERROR;
}
- inline status_t File::write(char * buffer, int32_t length) {
+ inline status_t File::write(char * buffer, uint32_t length) {
if(buffer == NULL) {
return CAPU_EINVAL;
}
Modified: incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/arch/Windows/File.inc
URL: http://svn.apache.org/viewvc/incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/arch/Windows/File.inc?rev=1368575&r1=1368574&r2=1368575&view=diff
==============================================================================
--- incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/arch/Windows/File.inc (original)
+++ incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/include/capu/os/arch/Windows/File.inc Thu Aug 2 16:17:22 2012
@@ -50,7 +50,7 @@
return (feof(mHandle) != 0);
}
- inline status_t File::read(char * buffer, int32_t length, int32_t* numBytes) {
+ inline status_t File::read(char * buffer, uint32_t length, int32_t* numBytes) {
if(buffer == NULL) {
return CAPU_EINVAL;
}
@@ -75,7 +75,7 @@
return CAPU_ERROR;
}
- inline status_t File::write(char * buffer, int32_t length) {
+ inline status_t File::write(char * buffer, uint32_t length) {
if(buffer == NULL) {
return CAPU_EINVAL;
}
Modified: incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/AtomicOperationTest.cpp
URL: http://svn.apache.org/viewvc/incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/AtomicOperationTest.cpp?rev=1368575&r1=1368574&r2=1368575&view=diff
==============================================================================
--- incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/AtomicOperationTest.cpp (original)
+++ incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/AtomicOperationTest.cpp Thu Aug 2 16:17:22 2012
@@ -25,27 +25,27 @@
TEST(AtomicOperation,Add) {
capu::uint32_t val = 100;
capu::uint32_t ret = capu::AtomicOperation::AtomicAdd32(val, 3);
- EXPECT_EQ((capu::uint32_t) 103,val);
- EXPECT_EQ(ret, 100);
+ EXPECT_EQ(103u,val);
+ EXPECT_EQ(100u, ret);
}
TEST(AtomicOperation,Sub) {
capu::uint32_t val = 13;
capu::uint32_t ret = capu::AtomicOperation::AtomicSub32(val, 5);
- EXPECT_EQ((capu::uint32_t) 8,val);
- EXPECT_EQ(ret, 13);
+ EXPECT_EQ(8u,val);
+ EXPECT_EQ(13u, ret);
}
TEST(AtomicOperation,Inc) {
capu::uint32_t val = 1;
capu::uint32_t ret = capu::AtomicOperation::AtomicInc32(val);
- EXPECT_EQ((capu::uint32_t) 2,val);
- EXPECT_EQ(ret, 1);
+ EXPECT_EQ(2u,val);
+ EXPECT_EQ(1u, ret);
}
TEST(AtomicOperation,Dec) {
capu::uint32_t val = 3;
capu::uint32_t ret = capu::AtomicOperation::AtomicDec32(val);
- EXPECT_EQ((capu::uint32_t) 2,val);
- EXPECT_EQ(ret, 3);
-}
\ No newline at end of file
+ EXPECT_EQ(2u,val);
+ EXPECT_EQ(3u, ret);
+}
Modified: incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/FileTest.cpp
URL: http://svn.apache.org/viewvc/incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/FileTest.cpp?rev=1368575&r1=1368574&r2=1368575&view=diff
==============================================================================
--- incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/FileTest.cpp (original)
+++ incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/FileTest.cpp Thu Aug 2 16:17:22 2012
@@ -102,7 +102,7 @@ TEST(File, ReadTest) {
memset(buf2, 0, sizeof(buf2));
status = f3->read(buf2, strlen(buf1), &read);
EXPECT_TRUE(status == capu::CAPU_OK);
- EXPECT_TRUE(read == strlen(buf1));
+ EXPECT_TRUE(read == (capu::uint32_t)strlen(buf1));
delete f3;
// read data
@@ -113,7 +113,7 @@ TEST(File, ReadTest) {
memset(buf2, 0, sizeof(buf2));
status = f4->read(buf2, strlen(buf1), NULL);
EXPECT_TRUE(status == capu::CAPU_OK);
- EXPECT_TRUE(read == strlen(buf1));
+ EXPECT_TRUE(read == (capu::uint32_t)strlen(buf1));
delete f4;
// read data Eof
@@ -125,7 +125,7 @@ TEST(File, ReadTest) {
memset(buf2, 0, sizeof(buf2));
status = f5->read(buf2, sizeof(buf2), &read);
EXPECT_TRUE(status == capu::CAPU_EOF);
- EXPECT_TRUE(read == strlen(buf1));
+ EXPECT_TRUE(read == (capu::uint32_t)strlen(buf1));
EXPECT_TRUE(strcmp(buf1, buf2) == 0);
delete f5;
}
Modified: incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/arch/X86_32/AtomicOperation.inc
URL: http://svn.apache.org/viewvc/incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/arch/X86_32/AtomicOperation.inc?rev=1368575&r1=1368574&r2=1368575&view=diff
==============================================================================
--- incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/arch/X86_32/AtomicOperation.inc (original)
+++ incubator/etch/trunk/binding-cpp/runtime/lib/capu/modules/capu/test/os/arch/X86_32/AtomicOperation.inc Thu Aug 2 16:17:22 2012
@@ -21,13 +21,13 @@
TEST(AtomicOperation, Add_Overflow_X86_32) {
capu::uint32_t val = 4294967295u;
capu::uint32_t ret = capu::AtomicOperation::AtomicAdd32(val, 3);
- EXPECT_EQ((capu::uint32_t) 2, val);
- EXPECT_EQ(ret, 4294967295u);
+ EXPECT_EQ(2u, val);
+ EXPECT_EQ(4294967295u, ret);
}
TEST(AtomicOperation, Sub_Overflow_X86_32) {
capu::uint32_t val = 0;
capu::uint32_t ret = capu::AtomicOperation::AtomicSub32(val, 5);
- EXPECT_EQ((capu::uint32_t) 4294967291u, val);
- EXPECT_EQ(ret, 0u);
+ EXPECT_EQ(4294967291u, val);
+ EXPECT_EQ(0u, ret);
}
\ No newline at end of file