You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by gi...@git.apache.org on 2017/08/02 00:00:37 UTC

[GitHub] rdhabalia opened a new pull request #619: make batch-ack thread-safe

rdhabalia opened a new pull request #619: make batch-ack thread-safe
URL: https://github.com/apache/incubator-pulsar/pull/619
 
 
   ### Motivation
   
   if consumer acks batch-messages concurrently, then client-consumer is not acking the message to broker even if consumer acks all batch-Index-msg with in that batch-message. `BitSet` which tracks unack-batch-message is not thread-safe and it accessed by multiple thread while acking and therefore, it fails to conclude that all messages have been acked.
   
   ### Modifications
   
   make access of `unack-BitSet` thread-safe.
   
   ### Result
   
   batch-msg ack will be thread-safe.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services