You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/12 22:34:04 UTC
[GitHub] [spark] huaxingao opened a new pull request #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
huaxingao opened a new pull request #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555
### What changes were proposed in this pull request?
There are three changes in this PR:
1. use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suites (similar to https://github.com/apache/spark/pull/26396)
2. Put common code in ```Summarizer.getRegressionSummarizers``` and ```Summarizer.getClassificationSummarizers```.
3. Move ```MultiClassSummarizer``` from ```LogisticRegression``` to ```ml.stat``` (this seems to be a better place since ```MultiClassSummarizer``` is not only used by ```LogisticRegression``` but also several other classes).
### Why are the changes needed?
Minimize code duplication and improve performance
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
existing test suites.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-587687116
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118648/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a change in pull request #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#discussion_r380469360
##########
File path: mllib/src/main/scala/org/apache/spark/ml/stat/MultiClassSummarizer.scala
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ml.stat
+
+import scala.collection.mutable
+
+
+/**
+ * MultiClassSummarizer computes the number of distinct labels and corresponding counts,
+ * and validates the data to see if the labels used for k class multi-label classification
+ * are in the range of {0, 1, ..., k - 1} in an online fashion.
+ *
+ * Two MultilabelSummarizer can be merged together to have a statistical summary of the
+ * corresponding joint dataset.
+ */
+private[ml] class MultiClassSummarizer extends Serializable {
+ // The first element of value in distinctMap is the actually number of instances,
+ // and the second element of value is sum of the weights.
+ private val distinctMap = new mutable.HashMap[Int, (Long, Double)]
+ private var totalInvalidCnt: Long = 0L
+
+ /**
+ * Add a new label into this MultilabelSummarizer, and update the distinct map.
+ *
+ * @param label The label for this data point.
+ * @param weight The weight of this instances.
+ * @return This MultilabelSummarizer
+ */
+ def add(label: Double, weight: Double = 1.0): MultiClassSummarizer = {
+ require(weight >= 0.0, s"instance weight, $weight has to be >= 0.0")
+
+ if (weight == 0.0) return this
+
+ if (label - label.toInt != 0.0 || label < 0) {
+ totalInvalidCnt += 1
+ this
+ }
+ else {
+ val (counts: Long, weightSum: Double) = distinctMap.getOrElse(label.toInt, (0L, 0.0))
+ distinctMap.put(label.toInt, (counts + 1L, weightSum + weight))
+ this
+ }
+ }
+
+ /**
+ * Merge another MultilabelSummarizer, and update the distinct map.
+ * (Note that it will merge the smaller distinct map into the larger one using in-place
+ * merging, so either `this` or `other` object will be modified and returned.)
+ *
+ * @param other The other MultilabelSummarizer to be merged.
+ * @return Merged MultilabelSummarizer object.
+ */
+ def merge(other: MultiClassSummarizer): MultiClassSummarizer = {
+ val (largeMap, smallMap) = if (this.distinctMap.size > other.distinctMap.size) {
+ (this, other)
+ } else {
+ (other, this)
+ }
+ smallMap.distinctMap.foreach {
+ case (key, value) =>
+ val (counts: Long, weightSum: Double) = largeMap.distinctMap.getOrElse(key, (0L, 0.0))
+ largeMap.distinctMap.put(key, (counts + value._1, weightSum + value._2))
+ }
+ largeMap.totalInvalidCnt += smallMap.totalInvalidCnt
+ largeMap
+ }
+
+ /** @return The total invalid input counts. */
+ def countInvalid: Long = totalInvalidCnt
+
+ /** @return The number of distinct labels in the input dataset. */
+ def numClasses: Int = if (distinctMap.isEmpty) 0 else distinctMap.keySet.max + 1
Review comment:
nit: `distinctMap.keysIterator.max + 1`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27555: [SPARK-30802][ML] Use
Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585455680
**[Test build #118326 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118326/testReport)** for PR 27555 at commit [`1745a5d`](https://github.com/apache/spark/commit/1745a5dc7f8273ee971d98fa1c4232b383679f58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-586393888
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-587595757
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23401/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a change in pull request #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#discussion_r380468433
##########
File path: mllib/src/main/scala/org/apache/spark/ml/stat/MultiClassSummarizer.scala
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ml.stat
+
+import scala.collection.mutable
+
+
+/**
+ * MultiClassSummarizer computes the number of distinct labels and corresponding counts,
+ * and validates the data to see if the labels used for k class multi-label classification
+ * are in the range of {0, 1, ..., k - 1} in an online fashion.
+ *
+ * Two MultilabelSummarizer can be merged together to have a statistical summary of the
+ * corresponding joint dataset.
+ */
+private[ml] class MultiClassSummarizer extends Serializable {
+ // The first element of value in distinctMap is the actually number of instances,
+ // and the second element of value is sum of the weights.
+ private val distinctMap = new mutable.HashMap[Int, (Long, Double)]
+ private var totalInvalidCnt: Long = 0L
+
+ /**
+ * Add a new label into this MultilabelSummarizer, and update the distinct map.
+ *
+ * @param label The label for this data point.
+ * @param weight The weight of this instances.
+ * @return This MultilabelSummarizer
+ */
+ def add(label: Double, weight: Double = 1.0): MultiClassSummarizer = {
+ require(weight >= 0.0, s"instance weight, $weight has to be >= 0.0")
+
+ if (weight == 0.0) return this
+
+ if (label - label.toInt != 0.0 || label < 0) {
Review comment:
```scala
if (label - label.toInt != 0.0 || label < 0) {
totalInvalidCnt += 1
} else {
val (counts: Long, weightSum: Double) = distinctMap.getOrElse(label.toInt, (0L, 0.0))
distinctMap.put(label.toInt, (counts + 1L, weightSum + weight))
}
this
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585480907
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118326/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585480738
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585453246
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23083/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-586393899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23199/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-586393888
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on issue #27555: [SPARK-30802][ML] Use
Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
Posted by GitBox <gi...@apache.org>.
huaxingao commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-588532638
Thanks! @srowen @zhengruifeng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-586421006
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27555: [SPARK-30802][ML] Use
Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585480534
**[Test build #118326 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118326/testReport)** for PR 27555 at commit [`1745a5d`](https://github.com/apache/spark/commit/1745a5dc7f8273ee971d98fa1c4232b383679f58).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585455680
**[Test build #118326 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118326/testReport)** for PR 27555 at commit [`1745a5d`](https://github.com/apache/spark/commit/1745a5dc7f8273ee971d98fa1c4232b383679f58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585452775
**[Test build #118325 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118325/testReport)** for PR 27555 at commit [`56df050`](https://github.com/apache/spark/commit/56df050c92801dd2cb7b0c0721d4c8fee0c1412a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585480898
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585480743
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118325/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585480907
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118326/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #27555: [SPARK-30802][ML] Use
Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-588528472
Merged to master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-586421006
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585453234
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-587595739
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-586392786
**[Test build #118442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118442/testReport)** for PR 27555 at commit [`6b6944f`](https://github.com/apache/spark/commit/6b6944f655e5f7726e03c3a4dd0b671929b91ee7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27555: [SPARK-30802][ML] Use
Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-587598518
**[Test build #118648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118648/testReport)** for PR 27555 at commit [`2274c93`](https://github.com/apache/spark/commit/2274c9313cc2fb1e66282593aed2628a430ea9f6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-587687116
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118648/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27555: [SPARK-30802][ML] Use
Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585452775
**[Test build #118325 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118325/testReport)** for PR 27555 at commit [`56df050`](https://github.com/apache/spark/commit/56df050c92801dd2cb7b0c0721d4c8fee0c1412a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-586393899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23199/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27555: [SPARK-30802][ML] Use
Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-586392786
**[Test build #118442 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118442/testReport)** for PR 27555 at commit [`6b6944f`](https://github.com/apache/spark/commit/6b6944f655e5f7726e03c3a4dd0b671929b91ee7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27555: [SPARK-30802][ML] Use
Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-587685582
**[Test build #118648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118648/testReport)** for PR 27555 at commit [`2274c93`](https://github.com/apache/spark/commit/2274c9313cc2fb1e66282593aed2628a430ea9f6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585480898
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a change in pull request #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#discussion_r379289047
##########
File path: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala
##########
@@ -202,6 +204,38 @@ object Summarizer extends Logging {
val (metrics, computeMetrics) = getRelevantMetrics(requested)
new SummarizerBuffer(metrics, computeMetrics)
}
+
+ /** Get regression feature and label summarizers for provided data. */
+ private[spark] def getRegressionSummarizers(
Review comment:
`private[ml]` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on a change in pull request #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#discussion_r379556835
##########
File path: mllib/src/main/scala/org/apache/spark/ml/stat/Summarizer.scala
##########
@@ -202,6 +204,38 @@ object Summarizer extends Logging {
val (metrics, computeMetrics) = getRelevantMetrics(requested)
new SummarizerBuffer(metrics, computeMetrics)
}
+
+ /** Get regression feature and label summarizers for provided data. */
+ private[spark] def getRegressionSummarizers(
Review comment:
Thanks! Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585480738
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585453246
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23083/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27555: [SPARK-30802][ML] Use
Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-586420619
**[Test build #118442 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118442/testReport)** for PR 27555 at commit [`6b6944f`](https://github.com/apache/spark/commit/6b6944f655e5f7726e03c3a4dd0b671929b91ee7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585480743
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118325/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-587595757
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23401/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-587595739
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-587687068
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-587598518
**[Test build #118648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118648/testReport)** for PR 27555 at commit [`2274c93`](https://github.com/apache/spark/commit/2274c9313cc2fb1e66282593aed2628a430ea9f6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-586421017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118442/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-586421017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118442/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #27555: [SPARK-30802][ML] Use
Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27555: [SPARK-30802][ML] Use
Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585480354
**[Test build #118325 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118325/testReport)** for PR 27555 at commit [`56df050`](https://github.com/apache/spark/commit/56df050c92801dd2cb7b0c0721d4c8fee0c1412a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27555:
[SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in
Aggregator test suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-585453234
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27555: [SPARK-30802][ML]
Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test
suite
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27555: [SPARK-30802][ML] Use Summarizer instead of MultivariateOnlineSummarizer in Aggregator test suite
URL: https://github.com/apache/spark/pull/27555#issuecomment-587687068
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org