You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/27 02:11:34 UTC

[GitHub] [shardingsphere] sandynz commented on a diff in pull request #21753: fix issue: add MySQL data type, linestring.

sandynz commented on code in PR #21753:
URL: https://github.com/apache/shardingsphere/pull/21753#discussion_r1006337343


##########
infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/dialect/datatypeloader/MySQLDataTypeLoader.java:
##########
@@ -46,6 +46,7 @@ public Map<String, Integer> load(final DatabaseMetaData database) throws SQLExce
         result.putIfAbsent("POLYGON", Types.BINARY);
         result.putIfAbsent("MULTIPOLYGON", Types.BINARY);
         result.putIfAbsent("MULTILINESTRING", Types.BINARY);
+        result.putIfAbsent("LINESTRING", Types.BINARY);

Review Comment:
   1, It's better to put `LINESTRING` before `MULTILINESTRING`;
   
   2, From the doc, looks there's `GEOMETRYCOLLECTION`, could it add here?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org