You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by "piglei (via GitHub)" <gi...@apache.org> on 2023/05/18 23:19:03 UTC

[GitHub] [apisix] piglei commented on pull request #9482: feat: Inform user when request /plugins/reload/ using wrong HTTP methods

piglei commented on PR #9482:
URL: https://github.com/apache/apisix/pull/9482#issuecomment-1553773107

   > I think it would be better to allow usage of GET method for plugin reload instead of warning user about wrong method usage, WDYT?
   
   Adding support for using GET to reload the plugins is okay and convenient. But consider that the "reload" endpoint is in the "/plugins/reload/<:string>" pattern family and the result of calling other endpoints via GET is reading information of the plugins, which has no side-effect at all. So, it's better to only support the PUT method for doing a plugin reload. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org