You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2022/07/24 08:48:06 UTC
[maven] branch MNG-7020 updated (21dfa0309 -> 0f8f22e40)
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a change to branch MNG-7020
in repository https://gitbox.apache.org/repos/asf/maven.git
omit 21dfa0309 [MNG-7020] Remove Maven 2 WagonExcluder backward compat code
add 5ce5591ae Fix minor typos
add 8125b3131 Fix typos in code
add 35b93b0a5 [MNG-7353] Add support for "mvn pluginPrefix:version:goal"
add 2d9918a2d Clean up dependency warnings by dependency:analyze
new 0f8f22e40 [MNG-7020] Remove Maven 2 WagonExcluder backward compat code
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (21dfa0309)
\
N -- N -- N refs/heads/MNG-7020 (0f8f22e40)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.github/workflows/maven_build_itself.yml | 2 +-
.../src/assembly/maven/lib/jansi-native/README.txt | 2 +-
.../maven/artifact/InvalidArtifactRTException.java | 2 +-
.../maven/artifact/repository/Authentication.java | 2 +-
.../MultipleArtifactsNotFoundException.java | 2 +-
.../java/org/apache/maven/repository/Proxy.java | 4 +-
.../repository/DefaultArtifactRepository.java | 2 +-
.../org/apache/maven/project/ProjectUtils.java | 2 +-
.../repository/MetadataResolutionRequest.java | 4 +-
.../repository/legacy/DefaultWagonManager.java | 2 +-
.../repository/legacy/LegacyRepositorySystem.java | 2 +-
.../resolver/DefaultLegacyArtifactCollector.java | 2 +-
.../resolver/transform/ArtifactTransformation.java | 8 +--
.../transform/ArtifactTransformationManager.java | 8 +--
.../repository/metadata/ArtifactMetadata.java | 2 +-
.../metadata/ClasspathTransformation.java | 2 +-
.../metadata/DefaultGraphConflictResolver.java | 2 +-
.../metadata/MetadataResolutionResult.java | 2 +-
.../maven/plugin-expressions/settings.paramdoc.xml | 4 +-
.../artifact/resolver/ArtifactResolverTest.java | 8 +--
.../maven/artifact/resolver/TestFileWagon.java | 2 +-
.../inheritance/t00/ProjectInheritanceTest.java | 2 +-
.../inheritance/t02/ProjectInheritanceTest.java | 2 +-
.../inheritance/t03/ProjectInheritanceTest.java | 2 +-
.../legacy/DefaultUpdateCheckManagerTest.java | 4 +-
maven-core/lifecycle-executor.txt | 2 +-
maven-core/plugin-manager.txt | 18 ++---
maven-core/pom.xml | 9 +--
.../maven/DefaultProjectDependenciesResolver.java | 4 +-
.../apache/maven/ProjectDependenciesResolver.java | 12 ++--
.../metadata/io/MetadataParseException.java | 2 +-
.../configuration/BeanConfigurationRequest.java | 2 +-
.../java/org/apache/maven/eventspy/EventSpy.java | 2 +-
.../eventspy/internal/EventSpyDispatcher.java | 2 +-
.../internal/EventSpyExecutionListener.java | 2 +-
.../internal/EventSpyRepositoryListener.java | 2 +-
.../execution/DefaultMavenExecutionRequest.java | 2 +-
.../maven/execution/ProjectDependencyGraph.java | 4 +-
.../maven/graph/DefaultProjectDependencyGraph.java | 2 +-
.../apache/maven/lifecycle/LifecycleExecutor.java | 2 +-
.../internal/DefaultLifecycleMappingDelegate.java | 2 +-
.../DefaultLifecycleTaskSegmentCalculator.java | 2 +-
.../internal/LifecycleDependencyResolver.java | 2 +-
.../lifecycle/internal/MojoDescriptorCreator.java | 37 ++++++----
.../maven/lifecycle/internal/ProjectBuildList.java | 2 +-
.../maven/lifecycle/internal/ProjectSegment.java | 2 +-
.../maven/lifecycle/internal/builder/Builder.java | 2 +-
.../apache/maven/plugin/MavenPluginManager.java | 2 +-
.../maven/plugin/PluginContainerException.java | 2 +-
.../plugin/internal/MavenPluginValidator.java | 2 +-
.../org/apache/maven/project/MavenProject.java | 12 ++--
.../org/apache/maven/project/ProjectBuilder.java | 4 +-
.../org/apache/maven/project/ProjectSorter.java | 4 +-
.../project/artifact/MavenMetadataSource.java | 4 +-
.../collector/MultiModuleCollectionStrategy.java | 8 +--
.../src/site/apt/configuration-management.apt | 2 +-
maven-core/src/site/apt/inheritance.apt | 2 +-
.../maven/lifecycle/LifecycleExecutorTest.java | 2 +-
.../maven/lifecycle/MavenExecutionPlanTest.java | 8 +--
.../lifecycle/internal/PhaseRecorderTest.java | 2 +-
.../internal/builder/BuilderCommonTest.java | 2 +-
.../ConcurrencyDependencyGraphTest.java | 2 +-
.../stub/LifecycleExecutionPlanCalculatorStub.java | 4 +-
.../stub/ProjectDependenciesResolverStub.java | 2 +-
.../internal/stub/ProjectDependencyGraphStub.java | 2 +-
.../stub/ProjectDependencyGraphStubTest.java | 6 +-
.../apache/maven/project/PomConstructionTest.java | 2 +-
.../pom.xml | 2 +-
.../sub/pom.xml | 2 +-
.../limited-inheritance/pom.xml | 2 +-
maven-embedder/pom.xml | 14 ++++
.../org/apache/maven/cli/CLIReportingUtils.java | 2 +-
.../main/java/org/apache/maven/cli/MavenCli.java | 8 +--
.../java/org/apache/maven/cli/MavenCliTest.java | 6 +-
.../building/DefaultModelBuildingRequest.java | 2 +-
.../model/building/DefaultModelProcessor.java | 4 +-
.../model/building/ModelBuildingException.java | 2 +-
.../org/apache/maven/model/building/ModelData.java | 2 +-
.../model/building/ModelProblemCollectorExt.java | 2 +-
.../model/building/ModelSourceTransformer.java | 2 +-
.../apache/maven/model/io/ModelParseException.java | 2 +-
.../apache/maven/model/locator/ModelLocator.java | 2 +-
.../maven/model/resolution/ModelResolver.java | 4 +-
maven-model-builder/src/site/apt/index.apt | 4 +-
.../maven/model/building/FileModelSourceTest.java | 6 +-
.../missing-plugin-dependency-groupId.xml | 2 +-
.../maven/model/transform/ParentXMLFilterTest.java | 2 +-
maven-model/src/main/mdo/maven.mdo | 4 +-
.../maven/plugin/descriptor/MojoDescriptor.java | 6 +-
maven-plugin-api/src/main/mdo/plugin.mdo | 2 +-
maven-repository-metadata/src/site/apt/index.apt | 3 +-
maven-settings-builder/pom.xml | 4 ++
.../building/DefaultSettingsBuildingRequest.java | 2 +-
.../building/SettingsBuildingException.java | 2 +-
.../maven/settings/io/SettingsParseException.java | 2 +-
.../org/apache/maven/settings/RuntimeInfo.java | 2 +-
maven-toolchain-builder/pom.xml | 84 +++++++++++-----------
.../building/ToolchainsBuildingException.java | 2 +-
.../toolchain/io/ToolchainsParseException.java | 2 +-
99 files changed, 240 insertions(+), 213 deletions(-)
[maven] 01/01: [MNG-7020] Remove Maven 2 WagonExcluder backward compat code
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch MNG-7020
in repository https://gitbox.apache.org/repos/asf/maven.git
commit 0f8f22e404c65594d0af5f5151d551dd7f64afc5
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Fri Nov 13 23:25:52 2020 +0100
[MNG-7020] Remove Maven 2 WagonExcluder backward compat code
This closes #394
---
.../DefaultPluginDependenciesResolver.java | 7 +-
.../PluginDependencyResolutionListener.java | 150 ---------------------
.../maven/plugin/internal/WagonExcluder.java | 109 ---------------
3 files changed, 1 insertion(+), 265 deletions(-)
diff --git a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginDependenciesResolver.java b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginDependenciesResolver.java
index 076a3cbfe..a31ca6201 100644
--- a/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginDependenciesResolver.java
+++ b/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginDependenciesResolver.java
@@ -42,7 +42,6 @@ import org.eclipse.aether.artifact.Artifact;
import org.eclipse.aether.artifact.DefaultArtifact;
import org.eclipse.aether.collection.CollectRequest;
import org.eclipse.aether.collection.DependencyCollectionException;
-import org.eclipse.aether.collection.DependencySelector;
import org.eclipse.aether.graph.DependencyFilter;
import org.eclipse.aether.graph.DependencyNode;
import org.eclipse.aether.graph.DependencyVisitor;
@@ -58,7 +57,6 @@ import org.eclipse.aether.util.artifact.JavaScopes;
import org.eclipse.aether.util.filter.AndDependencyFilter;
import org.eclipse.aether.util.filter.ScopeDependencyFilter;
import org.eclipse.aether.util.graph.manager.DependencyManagerUtils;
-import org.eclipse.aether.util.graph.selector.AndDependencySelector;
import org.eclipse.aether.util.repository.SimpleArtifactDescriptorPolicy;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -189,11 +187,8 @@ public class DefaultPluginDependenciesResolver
try
{
- DependencySelector selector =
- AndDependencySelector.newInstance( session.getDependencySelector(), new WagonExcluder() );
-
DefaultRepositorySystemSession pluginSession = new DefaultRepositorySystemSession( session );
- pluginSession.setDependencySelector( selector );
+ pluginSession.setDependencySelector( session.getDependencySelector() );
pluginSession.setDependencyGraphTransformer( session.getDependencyGraphTransformer() );
CollectRequest request = new CollectRequest();
diff --git a/maven-core/src/main/java/org/apache/maven/plugin/internal/PluginDependencyResolutionListener.java b/maven-core/src/main/java/org/apache/maven/plugin/internal/PluginDependencyResolutionListener.java
deleted file mode 100644
index 42eb80ed8..000000000
--- a/maven-core/src/main/java/org/apache/maven/plugin/internal/PluginDependencyResolutionListener.java
+++ /dev/null
@@ -1,150 +0,0 @@
-package org.apache.maven.plugin.internal;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import java.util.Collection;
-import java.util.IdentityHashMap;
-import java.util.LinkedList;
-import java.util.Map;
-
-import org.apache.maven.artifact.Artifact;
-import org.apache.maven.artifact.resolver.ResolutionListener;
-import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
-import org.apache.maven.artifact.versioning.VersionRange;
-
-/**
- * Assists in detecting wagon providers brought into the plugin class path via legacy Maven core artifacts (e.g.
- * maven-core:2.0.6) and excluding them. A plugin should be able to explicitly declare dependencies on specific wagons
- * for its use. However, the (old) wagons pulled in transitively via legacy Maven core artifacts are usually not
- * intended as dependencies and more importantly screw up artifact resolution because they would get preferred over the
- * core wagon versions. This is a hack to provide backward-compat with Maven 2 (MNG-4528, MNG-4561).
- *
- * @since 3.0
- * @author Benjamin Bentmann
- */
-class PluginDependencyResolutionListener
- implements ResolutionListener
-{
-
- private ArtifactFilter coreFilter;
-
- private LinkedList<Artifact> coreArtifacts = new LinkedList<>();
-
- private Artifact wagonProvider;
-
- private Map<Artifact, Object> bannedArtifacts = new IdentityHashMap<>();
-
- PluginDependencyResolutionListener( ArtifactFilter coreFilter )
- {
- this.coreFilter = coreFilter;
- }
-
- public void removeBannedDependencies( Collection<Artifact> artifacts )
- {
- if ( !bannedArtifacts.isEmpty() && artifacts != null )
- {
- artifacts.removeIf( artifact -> bannedArtifacts.containsKey( artifact ) );
- }
- }
-
- public void startProcessChildren( Artifact artifact )
- {
- if ( wagonProvider == null )
- {
- if ( isLegacyCoreArtifact( artifact ) )
- {
- coreArtifacts.addFirst( artifact );
- }
- else if ( !coreArtifacts.isEmpty() && isWagonProvider( artifact ) )
- {
- wagonProvider = artifact;
- bannedArtifacts.put( artifact, null );
- }
- }
- }
-
- private boolean isLegacyCoreArtifact( Artifact artifact )
- {
- String version = artifact.getVersion();
- return version != null && version.startsWith( "2." ) && !coreFilter.include( artifact );
- }
-
- public void endProcessChildren( Artifact artifact )
- {
- if ( wagonProvider == artifact )
- {
- wagonProvider = null;
- }
- else if ( coreArtifacts.peek() == artifact )
- {
- coreArtifacts.removeFirst();
- }
- }
-
- public void includeArtifact( Artifact artifact )
- {
- if ( wagonProvider != null )
- {
- bannedArtifacts.put( artifact, null );
- }
- }
-
- private boolean isWagonProvider( Artifact artifact )
- {
- if ( "org.apache.maven.wagon".equals( artifact.getGroupId() ) )
- {
- return artifact.getArtifactId().startsWith( "wagon-" );
- }
- return false;
- }
-
- public void manageArtifact( Artifact artifact, Artifact replacement )
- {
- }
-
- public void omitForCycle( Artifact artifact )
- {
- }
-
- public void omitForNearer( Artifact omitted, Artifact kept )
- {
- }
-
- public void restrictRange( Artifact artifact, Artifact replacement, VersionRange newRange )
- {
- }
-
- public void selectVersionFromRange( Artifact artifact )
- {
- }
-
- public void testArtifact( Artifact node )
- {
- }
-
- public void updateScope( Artifact artifact, String scope )
- {
- }
-
- public void updateScopeCurrentPom( Artifact artifact, String ignoredScope )
- {
- }
-
-}
diff --git a/maven-core/src/main/java/org/apache/maven/plugin/internal/WagonExcluder.java b/maven-core/src/main/java/org/apache/maven/plugin/internal/WagonExcluder.java
deleted file mode 100644
index d374cab9a..000000000
--- a/maven-core/src/main/java/org/apache/maven/plugin/internal/WagonExcluder.java
+++ /dev/null
@@ -1,109 +0,0 @@
-package org.apache.maven.plugin.internal;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import org.eclipse.aether.artifact.Artifact;
-import org.eclipse.aether.collection.DependencyCollectionContext;
-import org.eclipse.aether.collection.DependencySelector;
-import org.eclipse.aether.graph.Dependency;
-
-/**
- * Assists in detecting wagon providers brought into the plugin class path via legacy Maven core artifacts (e.g.
- * maven-core:2.0.6) and excluding them. A plugin should be able to explicitly declare dependencies on specific wagons
- * for its use. However, the (old) wagons pulled in transitively via legacy Maven core artifacts are usually not
- * intended as dependencies and more importantly screw up artifact resolution because they would get preferred over the
- * core wagon versions. This is a hack to provide backward-compat with Maven 2 (MNG-4528, MNG-4561).
- *
- * @author Benjamin Bentmann
- */
-class WagonExcluder
- implements DependencySelector
-{
-
- private final boolean coreArtifact;
-
- WagonExcluder()
- {
- this( false );
- }
-
- private WagonExcluder( boolean coreArtifact )
- {
- this.coreArtifact = coreArtifact;
- }
-
- public boolean selectDependency( Dependency dependency )
- {
- return !coreArtifact || !isWagonProvider( dependency.getArtifact() );
- }
-
- public DependencySelector deriveChildSelector( DependencyCollectionContext context )
- {
- if ( coreArtifact || !isLegacyCoreArtifact( context.getDependency().getArtifact() ) )
- {
- return this;
- }
- else
- {
- return new WagonExcluder( true );
- }
- }
-
- private boolean isLegacyCoreArtifact( Artifact artifact )
- {
- String version = artifact.getVersion();
- return version != null && version.startsWith( "2." ) && artifact.getArtifactId().startsWith( "maven-" )
- && artifact.getGroupId().equals( "org.apache.maven" );
- }
-
- private boolean isWagonProvider( Artifact artifact )
- {
- if ( "org.apache.maven.wagon".equals( artifact.getGroupId() ) )
- {
- return artifact.getArtifactId().startsWith( "wagon-" );
- }
- return false;
- }
-
- @Override
- public boolean equals( Object obj )
- {
- if ( obj == this )
- {
- return true;
- }
- else if ( obj == null || !getClass().equals( obj.getClass() ) )
- {
- return false;
- }
-
- WagonExcluder that = (WagonExcluder) obj;
- return coreArtifact == that.coreArtifact;
- }
-
- @Override
- public int hashCode()
- {
- int hash = getClass().hashCode();
- hash = hash * 31 + ( coreArtifact ? 1 : 0 );
- return hash;
- }
-
-}