[jira] [Commented] (CLOUDSTACK-9827) Storage tags stored in multiple places

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901936#comment-15901936 ] 

ASF GitHub Bot commented on CLOUDSTACK-9827:
--------------------------------------------

GitHub user nvazquez opened a pull request:

    https://github.com/apache/cloudstack/pull/1994

    CLOUDSTACK-9827: Storage tags stored in multiple places

    Issue description: https://issues.apache.org/jira/browse/CLOUDSTACK-9827
    
    ### Fixes
    - Create Primary Storage: Persist tags into `storage_pool_tags` instead of `storage_pool_details`
    - List Storage Tags: Queries `storage_pool_tags` table instead of `storage_tag_view`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nvazquez/cloudstack CLOUDSTACK-9827

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1994.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1994
    
----
commit e106919443949f704d77cee3dde7b36100609a73
Author: nvazquez <ni...@gmail.com>
Date:   2017-03-08T18:19:55Z

    CLOUDSTACK-9827: Storage tags stored in multiple places

----


> Storage tags stored in multiple places
> --------------------------------------
>
>                 Key: CLOUDSTACK-9827
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9827
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.10.0.0
>         Environment: N/A
>            Reporter: Mike Tutkowski
>            Priority: Blocker
>             Fix For: 4.10.0.0
>
>
> I marked this as a Blocker because it concerns me that we are not handling storage tags correctly in 4.10 and, as such, VM storage might get placed in locations that users don't want.
> From e-mails I sent to dev@ (most recent to oldest):
> If I add a new primary storage and give it a storage tag, the tag ends up in storage_pool_details.
> If I edit an existing storage pool’s storage tags, it places them in storage_pool_tags.
> **********
> I believe I have found another bug (one that we should either fix or examine in detail before releasing 4.10).
> It looks like we have a new table: cloud.storage_pool_tags.
> The addition of this table seems to have broken the listStorageTags API command. When this command runs, it doesn’t pick up any storage tags for me (and I know I have one storage tag).
> This data used to be stored in the cloud.storage_pool_details table. It’s good to put it in its own table, but will our upgrade process move the existing tags from storage_pool_details to storage_pool_tags?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)