You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/06/30 08:17:16 UTC
Review Request 67793: Combined headers and sources in
`MESOS_LINUX_FILES`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67793/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
The autotools build doesn't have a general style of separating
header and source files into separate build variables, so combine
both into the same `MESOS_LINUX_FILES` addition to make the style
more consistent.
Diffs
-----
src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
Diff: https://reviews.apache.org/r/67793/diff/1/
Testing
-------
make check (Fedora 28)
Thanks,
James Peach
Re: Review Request 67793: Combined headers and sources in
`MESOS_LINUX_FILES`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67793/#review205608
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67792, 67793]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 30, 2018, 8:17 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67793/
> -----------------------------------------------------------
>
> (Updated June 30, 2018, 8:17 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The autotools build doesn't have a general style of separating
> header and source files into separate build variables, so combine
> both into the same `MESOS_LINUX_FILES` addition to make the style
> more consistent.
>
>
> Diffs
> -----
>
> src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
>
>
> Diff: https://reviews.apache.org/r/67793/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67793: Combined headers and sources in
`MESOS_LINUX_FILES`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67793/#review205606
-----------------------------------------------------------
Fix it, then Ship it!
Looks like we never did follow through on distinguishing `libmesos_no_3rdparty_SOURCES` and `noinst_libmesos_no_3rdparty_HEADERS`. The form here certainly seems easier to modify, and we could always split out the headers explicitly without much work should we really want that.
src/Makefile.am
Lines 1369-1370 (patched)
<https://reviews.apache.org/r/67793/#comment288465>
At least in our "topological" include sort scheme these would come after `linux/systemd.hpp`. We seem to use the same scheme here.
- Benjamin Bannier
On June 30, 2018, 10:17 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67793/
> -----------------------------------------------------------
>
> (Updated June 30, 2018, 10:17 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The autotools build doesn't have a general style of separating
> header and source files into separate build variables, so combine
> both into the same `MESOS_LINUX_FILES` addition to make the style
> more consistent.
>
>
> Diffs
> -----
>
> src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
>
>
> Diff: https://reviews.apache.org/r/67793/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67793: Combined headers and sources in
`MESOS_LINUX_FILES`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67793/#review205609
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67792', '67793']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67793
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67793/logs/mesos-tests-stdout.log):
```
[ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (115 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1052 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (41 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (81 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (1144 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (1166 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (1249 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (1271 ms total)
[----------] Global test environment tear-down
[==========] 994 tests from 98 test cases ran. (611719 ms total)
[ PASSED ] 993 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerTest.ROOT_DOCKER_interface
1 FAILED TEST
YOU HAVE 220 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67793/logs/mesos-tests-stderr.log):
```
I0630 11:43:03.486884 21448 executor.cpp:182] Received SUBSCRIBED event
I0630 11:43:03.491884 21448 executor.cpp:186] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0630 11:43:03.491884 21448 executor.cpp:182] Received LAUNCH event
I0630 11:43:03.496879 21448 executor.cpp:679] Starting task 22f683b0-007e-4720-a686-b297971c0fd7
I0630 11:43:03.577881 21448 executor.cpp:499] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0630 11:43:03.645887 21448 executor.cpp:693] Forked command at 20864
I0630 11:43:03.678889 8588 exec.cpp:445] Executor asked to shutdown
I0630 11:43:03.679889 22504 executor.cpp:182] Received SHUTDOWN event
I0630 11:43:03.679889 22504 executor.cpp:796] Shutting down
I0630 11:43:03.679889 22504 executor.cpp:909] Sending SIGTERM to process tree at pid 20eactivating framework 85766f3c-a084-440d-9311-6fcb747a728a-0000 (default) at scheduler-5ecf67e2-cd6d-4718-ae73-48be0a9223d5@192.10.1.6:51049
I0630 11:43:03.675886 4960 hierarchical.cpp:407] Deactivated framework 85766f3c-a084-440d-9311-6fcb747a728a-0000
I0630 11:43:03.676880 19044 master.cpp:11032] Updating the state of task 22f683b0-007e-4720-a686-b297971c0fd7 of framework 85766f3c-a084-440d-9311-6fcb747a728a-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0630 11:43:03.676880 7996 slave.cpp:3939] Shutting down framework 85766f3c-a084-440d-9311-6fcb747a728a-0000
I0630 11:43:03.676880 7996 slave.cpp:6660] Shutting down executor '22f683b0-007e-4720-a686-b297971c0fd7' of framework 85766f3c-a084-440d-9311-6fcb747a728a-0000 at executor(1)@192.10.1.6:51070
I0630 11:43:03.678889 7996 slave.cpp:931] Agent terminating
W0630 11:43:03.678889 7996 slave.cpp:3935] Ignoring shutdown framework 85766f3c-a084-440d-9311-6fcb747a728a-0000 because it is terminating
I0630 11:43:03.679889 19044 master.cpp:11131] Removing task 22f683b0-007e-4720-a686-b297971c0fd7 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 85766f3c-a084-440d-9311-6fcb747a728a-0000 on agent 85766f3c-a084-440d-9311-6fcb747a728a-S0 at slave(449)@192.10.1.6:51049 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0630 11:43:03.683897 7996 containerizer.cpp:2407] Destroying container 0283eef7-b968-413b-8dfb-42af52abcfda in RUNNING state
I0630 11:43:03.683897 19044 master.cpp:1330] Agent 85766f3c-a084-440d-9311-6fcb747a728a-S0 at slave(449)@192.10.1.6:51049 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0630 11:43:03.684883 7996 containerizer.cpp:3021] Transitioning the state of container 0283eef7-b968-413b-8dfb-42af52abcfda from RUNNING to DESTROYING
I0630 11:43:03.684883 19044 master.cpp:3340] Disconnecting agent 85766f3c-a084-440d-9311-6fcb747a728a-S0 at slave(449)@192.10.1.6:51049 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0630 11:43:03.684883 19044 master.cpp:3359] Deactivating agent 85766f3c-a084-440d-9311-6fcb747a728a-S0 at slave(449)@192.10.1.6:51049 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0630 11:43:03.684883 7996 launcher.cpp:155] Asked to destroy container 0283eef7-b968-413b-8dfb-42af52abcfda
I0630 11:43:03.684883 21664 hierarchical.cpp:346] Removed framework 85766f3c-a084-440d-9311-6fcb747a728a-0000
I0630 11:43:03.685890 21664 hierarchical.cpp:769] Agent 85766f3c-a084-440d-9311-6fcb747a728a-S0 deactivated
I0630 11:43:03.733886 21664 containerizer.cpp:2860] Container 0283eef7-b968-413b-8dfb-42af52abcfda has exited
I0630 11:43:03.761888 12772 master.cpp:1172] Master terminating
I0630 11:43:03.763898 4960 hierarchical.cpp:612] Removed agent 85766f3c-a084-440d-9311-6fcb747a728a-S0
I0630 11:43:04.116885 15952 process.cpp:940] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On June 30, 2018, 11:23 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67793/
> -----------------------------------------------------------
>
> (Updated June 30, 2018, 11:23 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The autotools build doesn't have a general style of separating
> header and source files into separate build variables, so combine
> both into the same `MESOS_LINUX_FILES` addition to make the style
> more consistent.
>
>
> Diffs
> -----
>
> src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
>
>
> Diff: https://reviews.apache.org/r/67793/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67793: Combined headers and sources in
`MESOS_LINUX_FILES`.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67793/
-----------------------------------------------------------
(Updated June 30, 2018, 11:23 a.m.)
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
The autotools build doesn't have a general style of separating
header and source files into separate build variables, so combine
both into the same `MESOS_LINUX_FILES` addition to make the style
more consistent.
Diffs (updated)
-----
src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
Diff: https://reviews.apache.org/r/67793/diff/2/
Changes: https://reviews.apache.org/r/67793/diff/1-2/
Testing
-------
make check (Fedora 28)
Thanks,
James Peach