You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/10 11:14:36 UTC

[GitHub] [arrow] jorisvandenbossche edited a comment on pull request #10486: ARROW-13016: [C++][Compute] Support Null type in Sum/Mean/MinMax aggregation

jorisvandenbossche edited a comment on pull request #10486:
URL: https://github.com/apache/arrow/pull/10486#issuecomment-858533111


   `Count` is indeed certainly not a problem for "null" type (since it only counting the values, not calculating anything with them). And also for `MinMax` it seems this kernel always returns a null for empty or all-null numeric arrays, so there wouldn't be an inconsistency here by enabling it for null type. 
   
   So it's mainly `Sum` that would give a type inconsistency. `Mean` might give less of a problem, because currently that kernel always returns a double regardless of the (numeric) input type.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org